Closed
Bug 1787680
Opened 2 years ago
Closed 2 years ago
Make CSSEditUtils static class
Categories
(Core :: DOM: Editor, task)
Tracking
()
RESOLVED
FIXED
106 Branch
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Actually, we alloc CSSEditUtils instance in HTMLEditor, but it is to use HTMLEditor in CSSEditUtils. I think that it is better to add a parameter as HTMLEditor instead of allocating CSSEditUtils.
|
Assignee | |
Comment 1•2 years ago
|
||
CSSEditUtils::IsCSSPrefChecked is used in HTMLEditor only, so we can move
mIsCSSPrefChecked to HTMLEditor.
|
|
Assignee | |
Comment 2•2 years ago
|
||
We can change all methods in CSSEditUtils to static method if we add
HTMLEditor parameter.
Depends on D155975
|
||
Updated•2 years ago
|
Blocks: redesign-editor-module
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/933638b65132 Part 1. Move mIsCSSPrefChecked to HTMLEditor. r=masayuki https://hg.mozilla.org/integration/autoland/rev/9ea7b8f101b3 Part 2. Don't create CSSEditUtils instance. r=masayuki
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/933638b65132
https://hg.mozilla.org/mozilla-central/rev/9ea7b8f101b3
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
|
||
Updated•2 years ago
|
status-firefox104:
--- → wontfix
status-firefox105:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•