Closed Bug 1787718 Opened 2 years ago Closed 1 year ago

Add pid of processes for Content process log lines

Categories

(Core :: DOM: Content Processes, enhancement, P3)

Product:
Core
Component:
DOM: Content Processes
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m6] [webdriver:external])

Attachments

(1 file, 1 obsolete file)

Bug 1787718 - [dom] Add process id to shutdown diagnostic log output.
48 bytes, text/x-phabricator-request
Details | Review

Over on bug 1769821 we are trying to figure out a shutdown hang of Firefox and I can see the following line in the logs:

[Parent 10340, Main Thread] WARNING: ContentParent: id=2f3ea321c00 - ShutDownProcess: Shutdown already pending.: file Z:/task_166175583971947/build/src/dom/ipc/ContentParent.cpp:1824

Sadly this makes it hard to easily find this process via the task manager. It would be great if log entries like these could also include the PID of the related content process.

The pid should be add in MaybeLogBlockShutdownDiagnostics. The Pid will be available.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1
Whiteboard: [webdriver:m4]
Whiteboard: [webdriver:m4] → [webdriver:m4][webdriver:external]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b5bc598452a
[dom] Add process id to shutdown diagnostic log output. r=smaug

https://hg.mozilla.org/mozilla-central/rev/9b5bc598452a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
See Also: → 1763625

Backed out as requested by Henrik.

Backout link: https://hg.mozilla.org/integration/autoland/rev/972d0006abb1b5160fa87e1754f2f1d23975c3d9

Status: RESOLVED → REOPENED
status-firefox106: fixed → ---
Flags: needinfo?(hskupin)
Resolution: FIXED → ---
Target Milestone: 106 Branch → ---

Landing of the patch on this bug is actually blocked on bug 1763625 now.

Status: REOPENED → ASSIGNED
Depends on: 1763625
Flags: needinfo?(hskupin)
See Also: 1763625 →
Whiteboard: [webdriver:m4][webdriver:external] → [webdriver:m4:blocked][webdriver:external]
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [webdriver:m4:blocked][webdriver:external] → [webdriver:backlog:blocked] [webdriver:external]
Assignee: hskupin → nobody
Attachment #9320456 - Attachment is obsolete: true
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Whiteboard: [webdriver:backlog:blocked] [webdriver:external] → [webdriver:m6] [webdriver:external]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfdefd3ceffa
[dom] Add process id to shutdown diagnostic log output. r=smaug

https://hg.mozilla.org/mozilla-central/rev/bfdefd3ceffa

Status: ASSIGNED → RESOLVED
Closed: 2 years ago → 1 year ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: