1787718 - Add pid of processes for Content process log lines

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Over on bug 1769821 we are trying to figure out a shutdown hang of Firefox and I can see the following line in the logs:

[Parent 10340, Main Thread] WARNING: ContentParent: id=2f3ea321c00 - ShutDownProcess: Shutdown already pending.: file Z:/task_166175583971947/build/src/dom/ipc/ContentParent.cpp:1824

Sadly this makes it hard to easily find this process via the task manager. It would be great if log entries like these could also include the PID of the related content process.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The pid should be add in MaybeLogBlockShutdownDiagnostics. The Pid will be available.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1787718 - [dom] Add process id to shutdown diagnostic log output.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b5bc598452a
[dom] Add process id to shutdown diagnostic log output. r=smaug

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9b5bc598452a

Comment 5

[Atila Butkovits]

Backed out as requested by Henrik.

Backout link: https://hg.mozilla.org/integration/autoland/rev/972d0006abb1b5160fa87e1754f2f1d23975c3d9

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landing of the patch on this bug is actually blocked on bug 1763625 now.

Comment 7

[Marian-Vasile Laza]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/972d0006abb1b5160fa87e1754f2f1d23975c3d9

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1787718 - [dom] Add process id to shutdown diagnostic log output.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfdefd3ceffa
[dom] Add process id to shutdown diagnostic log output. r=smaug

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bfdefd3ceffa