1787719 - Screenshot feature cuts off the right part of the website.

Status: RESOLVED WORKSFORME

(Firefox :: Screenshots, defect, P2)

Description

[Jan Iłowski]

Attachment: actual_behavior.png

Steps to reproduce:

I used Ctrl+Shift+S to take a screenshot of the whole site.
You can also reproduce

Actual results:

The screenshot tool only included a part of the website. About 25% of the site was cut-off from the right.

Expected results:

The screenshot tool should've included the WHOLE website in the picture.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sam Foster [:sfoster] (he/him)]

We need some more information to try and reproduce and track down the issue here. I'm not able to reproduce so far.

• What method did you use to capture that screenshot? Screenshots offers "Save visible page", "Save full page", or you drag a bounding box on the area of the page you want to capture, or hover an element on the page whose rectangle encompasses the area you want to capture.
• What OS are you running Firefox on when you run into this problem?
• Do you have multiple displays active when this happens?
• Can you attach or paste the text from about:support

Comment 3

[Jan Iłowski]

Attachment: about:support

> * What method did you use to capture that screenshot? Screenshots offers "Save visible page", "Save full page", or you drag a bounding box on the area of the page you want to capture, or hover an element on the page whose rectangle encompasses the area you want to capture. 
As I have mentioned in my original report, my aim was to capture the whole website.

> * What OS are you running Firefox on when you run into this problem?
I have managed to replicate this bug on Linux (Artix) and MacOS
 
> * Do you have multiple displays active when this happens? 
No.

> * Can you attach or paste the text from about:support

Comment 4

[Yunis]

Attachment: about-support.txt

Comment 5

[Yunis]

I am having the same problem, running 104.0.2. Attached about:support

Comment 6

[Rares Doghi, Desktop QA]

I tried to reproduce this issue on our end on a Mac Os 11.1, Ubuntu 20 and Windows 10 using Firefox Release, Beta and Nightly but after hitting the Shortcut Ctrl Shift S and then selecting Save Full Page or Save Visible it would always save the entire image, I couldnt reproduce this issue on our end.

I also Tried adding the extensions I saw in the about:support file like privacy badger, ublock and the Open Multiple URLs but to no success.

kontakt or Yunis can you please try to reproduce this issue in our latest Nightly build ? you can find the build here https://nightly.mozilla.org/, it might have been fixed with our latest versions of Firefox.

Also can you please test if the issue is reproducible in safe mode, here is a link that can help you:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 7

[Yunis]

Attachment: regular-ss.jpg

Regular screenshow of the window 9/9/2022

Comment 8

[Yunis]

Attachment: Screenshot 2022-09-09 at 14-47-28 Amazon.com. Spend less. Smile more.png

screenshot taken by rightclicking and choosing screenshot and full page of the same page

Comment 9

[Yunis]

I updated FF to 105.0b9 (64-bit) it still cuts off the right side of the amazon page today. 9/9/2022

Comment 10

[Jan Iłowski]

(In reply to Rares Doghi from comment #6)

I also Tried adding the extensions I saw in the about:support file like privacy badger, ublock and the Open Multiple URLs but to no success.
I have tried disabling the extensions, it's clearly not their fault.

kontakt or Yunis can you please try to reproduce this issue in our latest Nightly build ? you can find the build here https://nightly.mozilla.org/, it might have been fixed with our latest versions of Firefox.
I haven't managed to reproduce this error in the Nightly Version, however...

Also can you please test if the issue is reproducible in safe mode
it IS reproducible in the safe mode.

The issue disappeared from my FireFox when I deleted my prefs.js file. I assume it was either me, messing with the "about:"s (or an update that broke those files for some reason). I guess I got punished for being a nerd. Still have no idea what setting specifically caused the issue.
I have attached my new (working) prefs.js and my old (not working) prefs.jsOLD. I also attached diff output. Maybe someone more familiar with the construction of those files will be able to discern what's going on there :p

Comment 11

[Jan Iłowski]

Attachment: diff output of the working prefs.js file and not working one.

Comment 12

[Jan Iłowski]

Attachment: working

Comment 13

[Jan Iłowski]

Attachment: not working prefs.js

Comment 14

[Yunis]

Attachment: Screenshot 2022-09-09 at 17-46-07 Dummy Page.png

File name not page's title as normally should be

Comment 15

[Yunis]

If I change the settings screenshots.browser.component.enabled to Enable
The screenshot for full page works, but the title of the file is not the page's title as per the screenshot about it has a file name "Dummy page".

Comment 16

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 17

[Sam Foster [:sfoster] (he/him)]

(In reply to Yunis from comment #14)

Created attachment 9293996 [details]
Screenshot 2022-09-09 at 17-46-07 Dummy Page.png

File name not page's title as normally should be

Can you file that as a separate bug in this component (Firefox::Screenshots), thanks!

Comment 18

[Sam Foster [:sfoster] (he/him)]

I've looked through the diff comparing the old and new prefs.js, and I'm just not seeing any explanation for why the screen capture dimensions would have been wrong for this profile and now are correct. I've also tried dropping the not-working prefs into a new profile and I'm not able to reproduce. So I think I'm going to have to close this as works-for-me, and likely an artifact from one of the addons. If anyone has a better theory or is able to reproduce, please re-open this bug.

Comment 19

[Sam Foster [:sfoster] (he/him)]

:jrmuizel, do you see anything unusual in the graphics settings in attachment 9293392 [details] which would explain captureTab capturing only part of the page? I'm drawing a blank and have been unable to reproduce this.