1787783 - The "userEnabledActiveColorway" targeting parameter from the ASRouter page has no value if a custom theme is enabled

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 106.0a1 - Build ID: 20220829094551

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.5
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.
• Have a custom theme enabled from "about:addons>Themes".

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Navigate to the "about:newtab#asrouter" page and select the "Targeting" section.
3. Search for the "userEnabledActiveColorway" parameter and observe the displayed value.

[Expected result]:

• The "userEnabledActiveColorway" parameter is set to "false".

[Actual result]:

• The "userEnabledActiveColorway" targeting parameter from the ASRouter page has no value.

[Additional Notes]:

• If a colorway theme is applied the "userEnabledActiveColorway" parameter is set to "true".
• If a browser default theme is applied the "userEnabledActiveColorway" parameter is set to "false".
• Attached a screen recording of the issue.

Comment 1

[Meg Viar [:mviar]]

Functionally this is fine, but the return value should be converted to a boolean for consistency.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1787783 - return boolean for userEnabledActiveColorway targeting param

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a071b884af5
return boolean for userEnabledActiveColorway targeting param r=emcminn

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4a071b884af5

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220829214526) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm that the "userEnabledActiveColorway" targeting parameter is set to "false" if a custom theme is enabled.