1787955 - Dot stuffing doesn't work in NNTP-JS, article cut off at line only containing a dot

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[newsfan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36

Steps to reproduce:

Post a news article with a leading dot, so something like:

.1 dot
..2 dots
... 3 dots

Actual results:

The first dot of each line is removed upon receipt.

Expected results:

https://datatracker.ietf.org/doc/html/rfc3977 calls for "dot stuffing":

3. If any line of the data block begins with the "termination octet"
   ("." or %x2E), that line MUST be "dot-stuffed" by prepending an
   additional termination octet to that line of the block.

4. When a multi-line block is interpreted, the "dot-stuffing" MUST
   be undone; i.e., the recipient MUST ensure that, in any line
   beginning with the termination octet followed by octets other
   than a CRLF pair, that initial termination octet is disregarded.

(Seems similar to space-stuffing for format=flowed messages.)

Comment 1

[newsfan]

It is worse. A message is cut off if a line in the composition only consists of a dot. This is still working in the old C++ module.

Comment 2

[Ping Chen [:rnons] (away)]

Thanks, on it.

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1787955 - Fix dot-stuffing when posting NNTP article. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9786cf9408c3
Fix dot-stuffing when posting NNTP article. r=mkmelin

Comment 6

[Ping Chen [:rnons] (away)]

Comment on attachment 9292183 [details]
Bug 1787955 - Fix dot-stuffing when posting NNTP article. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Sending news article that has lines starting with dot may be clipped
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9292183 [details]
Bug 1787955 - Fix dot-stuffing when posting NNTP article. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 105.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/befff6d905ba

Comment 9

[Ping Chen [:rnons] (away)]

Comment on attachment 9292183 [details]
Bug 1787955 - Fix dot-stuffing when posting NNTP article. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Sending news article that has lines starting with dot may be clipped
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9292183 [details]
Bug 1787955 - Fix dot-stuffing when posting NNTP article. r=mkmelin

[Triage Comment]
approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.3.2:
https://hg.mozilla.org/releases/comm-esr102/rev/8a0838bce693