1787958 - Pillify before message saved or sent creates artifact pill for certain autocomplete matches: `doe >> [e-mail]`

Status: NEW

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Thomas D. (:thomas8)]

Regression found when QA testing Bug 1785851 - Ensure recipients are always pillified before a message is saved or sent.

106.0a1 (2022-08-29) (64-bit), Win10

STR

• have contact without display name (for ease of illustration), only email address: [e-mail] (sic). doe should be unique enough in your AB to bring this contact up as a top autocomplete match when typing doe.
• without confirming/pillifying this email address, click Save (or any other methods which imply saving, see bug 1785851, comment 0).
• Alternatively, edit an existing pill, select the entire email address, type doe without confirming, and click Save.
• check the resulting recipient pill

Actual

• Resulting pill is an artifact having >> which will make the email undeliverable: doe >> [e-mail]

Expected

• no artifact pill having >>
• I'm not a big fan of autocompleting without user's explicit confirmation, but if we want to pillify at this stage (assuming that the user is done and happy with the current top result of autocomplete), maybe that's what we need to do. Otherwise we'd have to create an error pill just having doe.

Comment 1

[Alessandro Castellani [:aleca]]

Ah, thanks for finding this. I knew something sketchy was going to happen with the "forced pillification".
Indeed, I think your intuition is correct and we shouldn't autocomplete, but only pillify what the user wrote.

Pillify and returning a "warning" pill it's better than arbitrarily auto-completing the first result, if the user doesn't deliberately confirm the autocomplete.

Comment 2

[Magnus Melin [:mkmelin]]

I would think it's still preferable to always autocomplete to the suggested value. Using half of it but not all will always be wrong.