Closed Bug 1788073 Opened 3 years ago Closed 3 years ago

Count marked cells when finalizing rather then when marking

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

We report telemetry on the marking rate, calculated from the number of cells marked and the time we spent in the marking phase.

The count of marked cells is calculated when marking but this is unnecessary because we already count the number of cells marked when we finalize arenas (and this mainly happens off thread).

This (slightly) simplifies marking.

There is a small discrepancy because this doesn't count atoms that are marked when we are not collecting the atoms zone, so this may affect the reported mark rate a little. I don't think it's important that this is accurate though, it's there to tell us if we regress marking preformance.

We already count the number of marked cells when finalizing arenas so use that
instead of counting in the mark phase as well.

Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79073b1a3af3 Compute mark count during sweeping r=sfink
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: