Lando's `config/milestone.txt` parsing is broken
Categories
(Conduit :: Lando, defect)
Tracking
(Not tracked)
People
(Reporter: sheehan, Assigned: sheehan)
Details
Attachments
(1 file)
Parsing of the config/milestone.txt file failed when trying to land an uplift to beta. Right now the parsing is done with a regex that parses the whole file. A more foolproof way to parse this version would be to just take the last line of the file and pass to a Version object, which is a more robust handling of the version.
It might be more bulletproof to parse the only line in the file that doesn't start with # and isn't empty.
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
(In reply to :glob ✱ from comment #1)
It might be more bulletproof to parse the only line in the file that doesn't start with
#and isn't empty.
That was my original implementation, but in review it was suggested to change to a regex. The regex failed in practice and now we basically just .strip().splitlines()[-1]. You can check the PR attached. :)
Description
•