[PERF] Windows event loop cleanup

VERIFIED FIXED in M12

Status

()

Core
XUL
P3
minor
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: Michael Lowe, Assigned: Kevin McCluskey (gone))

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
Attached file is a cleanup for the Windows event loop in
mozilla/widget/src/windows/nsAppShell.cpp

Please review for checkin.
(Reporter)

Comment 1

19 years ago
Created attachment 2579 [details]
Event loop improvement

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → WONTFIX

Comment 2

19 years ago
For the reasons I gave in the email response.
(Reporter)

Updated

19 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 3

19 years ago
Re-opening per my latest email comments.

Updated

19 years ago
Resolution: WONTFIX → ---

Updated

19 years ago
Assignee: troy → kmcclusk
Status: REOPENED → NEW
Component: Event Handling → XP Toolkit/Widgets

Comment 4

19 years ago
The reason for making the change is a potential improvement in UI
responsiveness.

If you cant get any system messages through the call to:

::PeekMessage(&msg, NULL, 0, WM_USER-1, PM_REMOVE)

then you block on:

keepGoing = ::GetMessage(&msg, NULL, 0, 0);

But, if several system and non-system messages are added to the event queue
before the call returns then you will end up processing the WM_USER
events before any system events (this is the order GetMessage returns events
from the queue) so there will be an event priority inversion. The opposite of
what you hope to achieve.
(Reporter)

Updated

19 years ago
Summary: Windows event loop cleanup → [PERF] Windows event loop cleanup
(Reporter)

Updated

19 years ago
Target Milestone: M12
(Reporter)

Comment 5

19 years ago
Can this be checked in now?
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

19 years ago
Applied patch 11/22/99 2:51PM.
(Reporter)

Updated

19 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.