Closed Bug 17881 Opened 26 years ago Closed 26 years ago

[PERF] Windows event loop cleanup

Categories

(Core :: XUL, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: michael.j.lowe, Assigned: kmcclusk)

Details

Attachments

(1 file)

Attached file is a cleanup for the Windows event loop in mozilla/widget/src/windows/nsAppShell.cpp Please review for checkin.
Attached file Event loop improvement
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
For the reasons I gave in the email response.
Status: RESOLVED → REOPENED
Re-opening per my latest email comments.
Resolution: WONTFIX → ---
Assignee: troy → kmcclusk
Status: REOPENED → NEW
Component: Event Handling → XP Toolkit/Widgets
The reason for making the change is a potential improvement in UI responsiveness. If you cant get any system messages through the call to: ::PeekMessage(&msg, NULL, 0, WM_USER-1, PM_REMOVE) then you block on: keepGoing = ::GetMessage(&msg, NULL, 0, 0); But, if several system and non-system messages are added to the event queue before the call returns then you will end up processing the WM_USER events before any system events (this is the order GetMessage returns events from the queue) so there will be an event priority inversion. The opposite of what you hope to achieve.
Summary: Windows event loop cleanup → [PERF] Windows event loop cleanup
Target Milestone: M12
Can this be checked in now?
Status: NEW → RESOLVED
Closed: 26 years ago26 years ago
Resolution: --- → FIXED
Applied patch 11/22/99 2:51PM.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: