Closed
Bug 17881
Opened 26 years ago
Closed 26 years ago
[PERF] Windows event loop cleanup
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: michael.j.lowe, Assigned: kmcclusk)
Details
Attachments
(1 file)
661 bytes,
text/plain
|
Details |
Attached file is a cleanup for the Windows event loop in
mozilla/widget/src/windows/nsAppShell.cpp
Please review for checkin.
Reporter | ||
Comment 1•26 years ago
|
||
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Reporter | ||
Comment 3•26 years ago
|
||
Re-opening per my latest email comments.
Assignee: troy → kmcclusk
Status: REOPENED → NEW
Component: Event Handling → XP Toolkit/Widgets
The reason for making the change is a potential improvement in UI
responsiveness.
If you cant get any system messages through the call to:
::PeekMessage(&msg, NULL, 0, WM_USER-1, PM_REMOVE)
then you block on:
keepGoing = ::GetMessage(&msg, NULL, 0, 0);
But, if several system and non-system messages are added to the event queue
before the call returns then you will end up processing the WM_USER
events before any system events (this is the order GetMessage returns events
from the queue) so there will be an event priority inversion. The opposite of
what you hope to achieve.
Reporter | ||
Updated•26 years ago
|
Summary: Windows event loop cleanup → [PERF] Windows event loop cleanup
Reporter | ||
Updated•26 years ago
|
Target Milestone: M12
Reporter | ||
Comment 5•26 years ago
|
||
Can this be checked in now?
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•26 years ago
|
||
Applied patch 11/22/99 2:51PM.
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•