1788157 - Running `cargo update` fails with "failed to resolve patches for `https://github.com/mozilla/uniffi-rs.git`"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #1783790 +++

This is happening again after the release of 0.19.4 and 0.19.5 on crates.io yesterday.

Full message:

error: failed to resolve patches for `https://github.com/mozilla/uniffi-rs.git`

Caused by:
  patch for `uniffi` in `https://github.com/mozilla/uniffi-rs.git` failed to resolve

Caused by:
  patch for `uniffi` in `registry `crates-io`` resolved to more than one candidate
  Found versions: 0.19.3, 0.19.4, 0.19.5
  Update the patch definition to select only one package.
  For example, add an `=` version requirement to the patch definition, such as `version = "=0.19.5"`.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1766045

:bdeankawamura, since you are the author of the regressor, bug 1766045, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

eek - sorry about that. FWIW, Jan-Erik was hoping to get https://github.com/mozilla/uniffi-rs/pull/1323 in before taking the new uniffi into m-c to avoid auditing a dependency.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1788157 - Straighten up uniffi Cargo.toml patches.

Without strict =version dependencies in the patch, cargo is lost when
new versions are published on crates.io.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8b2c4740e02
Straighten up uniffi Cargo.toml patches. r=markh

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d8b2c4740e02

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.