1788273 - Tweak popup alignment so that Wayland mirroring works bettter.

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

When you have a wayland popup aligned to the bottomcenter topleft as we have e.g. for the library menus, we can't come up with a request such that we end up mirroring correctly, see bug 1784876 for an example.

But we no longer have arrows on the panels and we really want the sides to align, so we can change the alignment properties and remove the large negative margins, which would allow Wayland to properly mirror them.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak

When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/368a7ce1b104
Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_ext_browserAction_popup_resize_bottom.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/61aabba8c2a349dede05dc3a264e7681bd78eb7f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OSoifuiSQWuQB6EVrY-SvQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=368a7ce1b104c8a111691387781457d99ab21dd9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=389282286&repo=autoland&lineNumber=3565

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2796340b53b8
Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2796340b53b8