Closed Bug 1788443 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35671 - [scroll-animations] Recalculate siblings for display:none and similar

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox106 fixed)

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35671 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35671
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[scroll-animations] Recalculate siblings for display:none and similar

We already recalculate subsequent siblings whenever the computed value
of scroll-timeline-name/axis changes, however this only applies when
both the old and new style exist. In other words, it does not work
properly when transitioning to/from display:none, or other cases where
an element is inserted/removed.

Fixed by returning kSiblingDescendantAffecting whenever a ComputedStyle
appears or disappears with a non-empty scroll-timeline-name.

Bug: 1317765
Change-Id: I904d448ad591d6c8a396af718cc2f0b91f7b211a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3859615
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040864}

PR 35671 applied with additional changes from upstream: 8845054e794d42da4d0469f71beb490913f3ac10, 260ab29a061a7bb48dc8eb9b45c2276c1fb183ac
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
FAIL: 5[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 15[GitHub]

Chrome

OK : 1
PASS: 1
FAIL: 15

Safari

OK : 1
PASS: 1
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative.html [wpt.fyi]
    • scroll-timeline-name is referenceable in animation-timeline on the declaring element itself: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name is referenceable in animation-timeline on that element's descendants: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name is referenceable in animation-timeline on that element's following siblings: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name is referenceable in animation-timeline on that element's following siblings' descendants: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name is not referenceable in animation-timeline on that element's previous siblings: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name is matched based on tree order, which considers siblings closer than parents: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name affects subsequent siblings when changed: FAIL (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name on inserted element affects subsequent siblings: FAIL (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name on removed element affects subsequent siblings: FAIL (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name on element leaving display:none affects subsequent siblings: FAIL (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-name on element becoming display:none affects subsequent siblings: FAIL (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-axis is block: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-axis is inline: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-axis is horizontal: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • scroll-timeline-axis is vertical: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2146214a872a [wpt PR 35671] - [scroll-animations] Recalculate siblings for display:none and similar, a=testonly https://hg.mozilla.org/integration/autoland/rev/644a532c2e77 [wpt PR 35671] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2146214a872a
https://hg.mozilla.org/mozilla-central/rev/644a532c2e77

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.