Closed
Bug 1788558
Opened 3 years ago
Closed 3 years ago
faulty no-op audio-device-change detection in MediaDecoderStateMachine
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: karlt, Assigned: pehrsons)
References
Details
Attachments
(1 file)
A check was introduced to attempt to detect when an audio device change is changing to the same device and skip the change.
However the device is always compared to nullptr, so the check is ineffective.
A method was added to return the actual audio device, but this does not override the nullptr method and so is not used.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → apehrson
Status: NEW → ASSIGNED
Priority: -- → P2
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9292654 -
Attachment description: Bug 1788558 - Set AudioDeviceInfo on media sinks properly. r?#media-playback-reviewers! → Bug 1788558 - Set AudioDeviceInfo on media sinks properly. r?alwu!, r?#media-playback-reviewers!
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/883c5dd590a1
Set AudioDeviceInfo on media sinks properly. r=media-playback-reviewers,alwu
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•