Extended Telemetry should be enabled for autoland builds
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: florian, Assigned: chutten)
References
Details
Attachments
(1 file)
The code at https://searchfox.org/mozilla-central/rev/fa81b64fc1a339e2b2b1f6a8637a689916e13c4e/toolkit/components/telemetry/app/TelemetryControllerBase.jsm#93-106 enables extended Telemetry for nightly, aurora, beta and local builds.
Extended Telemetry is not enabled on try server builds or autoland builds. There for opt builds we use the "default" update channel, and shippable (pgo) builds use the "nightly-try" and "nightly-autoland" update channels respectively.
This made bug 1784591 very difficult to figure out, and it took 18 days before bug 965392 was backed out, as the failure (which was almost a perma fail) could only be reproduced on shippable builds from the mozilla-central tree.
I confirmed with https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=90f4d156254cbddd6ddd4de4d5677fc216627f4e that the code in TelemetryControllerBase.jsm is what makes the difference between the shippable m-c builds and the others.
Chutten, do you have thoughts on what we should do? I think the nightly-autoland and nightly-try channels are definitely useful to include. I'm hesitant for the "default" channel for official builds. Having it would have made the bug less confusing, but there might be a good reason for it to not be included?
Feel free to adopt/adapt https://hg.mozilla.org/try/rev/8a5aef519e5770a18f485a5db07d45554369fb3b if you think it's a good approach.
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
Wow, geez, I'm sorry that took so long to work out.
The exclusion of MOZ_OFFICIAL default builds was deliberate as those could be single-channel releases from Linux distros. I'd certainly be willing to go ahead with adding nightly-autoland and nightly-try to the list of prerelease channels that'd turn canRecordExtended on.
Though... there's been a positive side effect to nightly-try and nightly-autoland not counting as prerelease. Tests that would fail when run against beta or release (because they test instrumentation only available on prerelease channels, but run the test regardless of channel) were caught earlier when run on autoland/try.
What do you think, Florian? Worth it?
|
Reporter | |
Comment 2•2 years ago
|
||
I think adding nightly-try and nightly-autoland to the list would be worth it. That would have been enough to have a backout of the patch within a day, and I'm not too concerned about testing the beta code paths, as there are beta simulation runs happening pretty frequently.
Having the failures also on normal opt builds would help a lot; maybe the way to do that would be to have new "try" and "autoland" update channels instead of "default" for these trees? This could probably be figured out in a separate bug, I don't know if it's a good idea or not.
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3308e461ffc Add 'nightly-autoland' and '-try' to list of Telemetry prerelease channels r=florian
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•