1788713 - Fix consuming default profile Firefox Messaging System targeting in background tasks

Status: RESOLVED FIXED

(Toolkit :: Background Tasks, defect)

Description

[Nick Alexander :nalexander [he/him]]

I forgot to specify the lock here, leading this to throw every time.

This is a weak point in the automated testing of this system: we have fairly good unit test coverage of the components but it's very difficult to have end-to-end integration tests that would catch oversights like this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1775138

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1788713 - Read default profile targeting with existing lock in `backgroundupdate` task. r?bytesized

Depends on D154468

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aa35620eb44
Read default profile targeting with existing lock in `backgroundupdate` task. r=bytesized,application-update-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0aa35620eb44

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nalexander, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 9292705 [details]
Bug 1788713 - Read default profile targeting with existing lock in backgroundupdate task. r?bytesized

Beta/Release Uplift Approval Request

• User impact if declined: This regression is in functionality added in Firefox 105. To the best of my knowledge, this doesn't impact the function of the background update process; it just prints a warning. We expect to use this new functionality only in 106, but we would like to test certain aspects in Beta 105. Therefore, I'd like to uplift.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a one word change, easily tested locally.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9292705 [details]
Bug 1788713 - Read default profile targeting with existing lock in backgroundupdate task. r?bytesized

Approved for 105.0b7.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ed35b8c9ae4