Closed Bug 1788713 Opened 3 months ago Closed 3 months ago

Fix consuming default profile Firefox Messaging System targeting in background tasks

Categories

(Toolkit :: Background Tasks, defect)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- wontfix
firefox105 --- fixed
firefox106 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I forgot to specify the lock here, leading this to throw every time.

This is a weak point in the automated testing of this system: we have fairly good unit test coverage of the components but it's very difficult to have end-to-end integration tests that would catch oversights like this.

Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0aa35620eb44
Read default profile targeting with existing lock in `backgroundupdate` task. r=bytesized,application-update-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

The patch landed in nightly and beta is affected.
:nalexander, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nalexander)

Comment on attachment 9292705 [details]
Bug 1788713 - Read default profile targeting with existing lock in backgroundupdate task. r?bytesized

Beta/Release Uplift Approval Request

  • User impact if declined: This regression is in functionality added in Firefox 105. To the best of my knowledge, this doesn't impact the function of the background update process; it just prints a warning. We expect to use this new functionality only in 106, but we would like to test certain aspects in Beta 105. Therefore, I'd like to uplift.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a one word change, easily tested locally.
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(nalexander)
Attachment #9292705 - Flags: approval-mozilla-beta?

Comment on attachment 9292705 [details]
Bug 1788713 - Read default profile targeting with existing lock in backgroundupdate task. r?bytesized

Approved for 105.0b7.

Attachment #9292705 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.