1788762 - Migrate devtools network observer to an ES module

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Julian Descottes [:jdescottes]]

The first step to make the DevTools network observer codebase shared with remote/ is to migrate the code from DevTools common JS modules to ESM.

In this bug we don't intend to change the interface of the observer at all, the goal is only to do a technical migration and to check that there are no issues when using (and debugging) the network observer modules

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To understand the topic right of this bug you are planning to move the observer or to place a ES copy of it into remote? Maybe we should clarify that a bit better in the summary.

Comment 2

[Julian Descottes [:jdescottes]]

The goal is only to migrate the common JS module to ESM. The modules will stay in the same location, will not move to remote, etc...

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788762 - Migrate devtools network observer to an ES module

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788762 - [devtools] Code cleanup devtools ChannelMap.sys.mjs

Depends on D156968

Cleanup of the ChannelMap class

• use private fields
• move static method to module-local method
• add comments
• rename methods to match behavior

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Requires some devtools changes before we can actually continue with this bug.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1788762 - [devtools] Load Network ESM in the devtools loader when we are in browser toolbox server.

Unfortunately, defineESModuleGetters is only contextual.
There is no argument to force it to load in another global.

This requires to switch to synchronous import, or,
introduce some temporary lazy getter until we migrate CommonJS modules to ESM.

At the end of ESM migration, we should mostly have one usage of loadInDevToolsLoader:true,
when we import DevToolsServer from Launcher.sys.mjs. Then, it should all be contextual.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788762 - [devtools] Load the NetworkObserver modules in DevToolsLoader if invisibleToDebugger is set

Depends on D156989

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fb16f9cb039
Migrate devtools network observer to an ES module r=ochameau
https://hg.mozilla.org/integration/autoland/rev/ea331a657dc9
[devtools] Code cleanup devtools ChannelMap.sys.mjs r=ochameau
https://hg.mozilla.org/integration/autoland/rev/f87b165f729e
[devtools] Load the NetworkObserver modules in DevToolsLoader if invisibleToDebugger is set r=ochameau

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7fb16f9cb039
https://hg.mozilla.org/mozilla-central/rev/ea331a657dc9
https://hg.mozilla.org/mozilla-central/rev/f87b165f729e