Closed
Bug 1788790
Opened 2 years ago
Closed 2 years ago
Debug builds crash when joining whereby room
Categories
(Core :: WebRTC, defect, P4)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: dbaker, Assigned: dbaker)
References
Details
Attachments
(2 files)
Changes to calculate remote timestamps using ntp time have exposed an issue where receiving a ntp timestamp not computed from Jan 1 1900 causes a crash in debug mode.
|
||
Updated•2 years ago
|
Keywords: regression
|
|
||
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1729455
:pehrsons, since you are the author of the regressor, bug 1729455, could you take a look?
For more information, please visit auto_nag documentation.
status-firefox104:
--- → affected
status-firefox105:
--- → affected
status-firefox106:
--- → affected
status-firefox-esr102:
--- → affected
status-firefox-esr91:
--- → unaffected
Flags: needinfo?(apehrson)
|
Assignee | |
Comment 2•2 years ago
|
||
This is the code changed.
This is the debug check failing
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → dbaker
Status: NEW → ASSIGNED
|
||
Comment 4•2 years ago
|
||
Removing the regression because this is debug-only.
Blocks: 1729455
status-firefox104:
affected → ---
status-firefox105:
affected → ---
status-firefox-esr102:
affected → ---
status-firefox-esr91:
unaffected → ---
Flags: needinfo?(apehrson)
Keywords: regression
No longer regressed by: 1729455
|
|
||
Updated•2 years ago
|
Attachment #9292745 -
Attachment description: Bug 1788790 - Only converting from ntp epoch if remote timestamp is large enough;r?pehrsons,jib → Bug 1788790 - Using TimeDelta instead of TimeStamp to allow for negative values when given non spec ntp;r?pehrsons,jib
|
|
Assignee | |
Comment 5•2 years ago
|
||
Pushed by dbaker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ef700cc5c01 Fixing static analysis error.;r=ng https://hg.mozilla.org/integration/autoland/rev/dee18f437555 Using TimeDelta instead of TimeStamp to allow for negative values when given non spec ntp;r=pehrsons
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0ef700cc5c01
https://hg.mozilla.org/mozilla-central/rev/dee18f437555
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•