Closed Bug 1788792 Opened 2 years ago Closed 2 years ago

Tab Pickup in Firefox View should also sync Containers

Categories

(Firefox :: Firefox View, enhancement, P3)

Firefox 106
Unspecified
All
enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: pjammers123mc, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Steps to reproduce:

Open any custom container tab on one device. Then, on a separate device, go to Tab Pickup in Firefox View to open it from there by left clicking on it.

Actual results:

Unless that site is set to always open in that container, it will open in the default container.

Expected results:

The tab should have opened in the same container considering Firefox Sync is working to keep the containers updated. While it is possible to right click and open each tab in the appropriate container, this change would make things more fluid.

The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox View' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Firefox View

When I open items from the synced tabs sidebar or the dropdown of the accounts menu, they also do not open in the same container as was used on the other device, and there is no colour / other information in that UI to indicate which container was used on the other device. I also don't see anything directly in the internal data format from sync that indicates which container to use. So I'm not sure if/how this is even possible.

Sammy/Mark is there support for this? I notice that the multi-account container add-on allows syncing containers, but apparently that support is not builtin? bug 1288858 and bug 1516455 are similar but haven't had activity in quite a while.

Blocks: firefox-view
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(skhamis)
Flags: needinfo?(markh)
OS: Unspecified → All
Whiteboard: [fidefe-2022-mr1-firefox-view]

That support is via the chrome.storage.sync extension API. Bug 1288858 looks like it should technically have been closed, but if it's bad if it's not working.

Flags: needinfo?(skhamis)
Flags: needinfo?(markh)
See Also: → 1288858

Note that's only synced if addons are, which is a footgun that might be biting you?

See Also: → 1789493

(In reply to Mark Hammond [:markh] [:mhammond] from comment #4)

Note that's only synced if addons are, which is a footgun that might be biting you?

Addons are synced, and the containers themselves also sync when I make changes, though I remember it being a bit slower.

(In reply to :Gijs (back Thu 8 Sep; he/him) from comment #2)

When I open items from the synced tabs sidebar or the dropdown of the accounts menu, they also do not open in the same container as was used on the other device, and there is no colour / other information in that UI to indicate which container was used on the other device. I also don't see anything directly in the internal data format from sync that indicates which container to use. So I'm not sure if/how this is even possible.

Sammy/Mark is there support for this? I notice that the multi-account container add-on allows syncing containers, but apparently that support is not builtin? bug 1288858 and bug 1516455 are similar but haven't had activity in quite a while.

Actually yeah, I forgot that normally sending tabs to other browsers doesn't remember the containers, including private mode. Should I have made this a more general enhancement request?

Should I have made this a more general enhancement request?

There's a long and sad history here, but the fact that containers require an addon means it's not really practical to have sync and send-tab become container aware.

(In reply to Mark Hammond [:markh] [:mhammond] from comment #7)

Should I have made this a more general enhancement request?

There's a long and sad history here, but the fact that containers require an addon means it's not really practical to have sync and send-tab become container aware.

Understood. Would it then otherwise be possible to include the "Open Link in New Container Tab" context menu option directly on the Tab Pickup area?

Severity: -- → S3
Priority: -- → P2
Severity: S3 → --

(In reply to Preston from comment #8)

(In reply to Mark Hammond [:markh] [:mhammond] from comment #7)

Should I have made this a more general enhancement request?

There's a long and sad history here, but the fact that containers require an addon means it's not really practical to have sync and send-tab become container aware.

Understood. Would it then otherwise be possible to include the "Open Link in New Container Tab" context menu option directly on the Tab Pickup area?

This option is already in the context menu for me - does it not appear for you (on an up-to-date nightly)? They are "just" links at this point, so they get a "normal" link context menu.

Flags: needinfo?(pjammers123mc)

(In reply to :Gijs (he/him) from comment #9)

(In reply to Preston from comment #8)

(In reply to Mark Hammond [:markh] [:mhammond] from comment #7)

Should I have made this a more general enhancement request?

There's a long and sad history here, but the fact that containers require an addon means it's not really practical to have sync and send-tab become container aware.

Understood. Would it then otherwise be possible to include the "Open Link in New Container Tab" context menu option directly on the Tab Pickup area?

This option is already in the context menu for me - does it not appear for you (on an up-to-date nightly)? They are "just" links at this point, so they get a "normal" link context menu.

It does appear. I just thought it'd be a bit more fluid to have it directly on the rectangle itself so it saves a button press and some navigation. If not, it doesn't really matter, I can definitely work with the context menu.

Flags: needinfo?(pjammers123mc)
Blocks: 1788692
No longer blocks: firefox-view
Priority: P2 → P3
Flags: needinfo?(jhall)
Flags: needinfo?(jhall) → needinfo?(rfambro)

This is more so of a "nice to have" capability. We've started to identify other areas of focus for FxView that should take precedence over any Containers related effort. Taking this off of our queue to focus on areas that will impact a higher volume of users.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(rfambro)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.