1788822 - "Firefox theme" website appearance setting is confusing (was: When opening Colorway Closet from about:addons with dark theme + Nightly Theme web appearance, page suddenly turns into light mode)

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[kpatenio]

Tested on 106.0a1 (2022-09-01) on MacOS Monterey 12.5.1

STR:

1. In MacOS system preferences, set OS theme to light mode
2. In about:preferences, ensure "Nightly Theme" is selected for web appearance
3. In about:addons, set active theme to dark theme
4. Obsrve how page is currently dark
5. Select "Try Colorways" button on the colorway closet card

Expected result:

• modal should load bold colorway intensity and browser scheme remains dark

Actual result:

• modal loads bold intensity colorway intensity, but browser scheme suddenly turns light, which can be very disorienting

I don't think this is related to Bug 1779714, although I stumbled upon this behaviour while working on that bug.

Notes

• Not reproducible if about:preferences web appearance is "System Theme" or the other light/dark themes

Comment 1

[kpatenio]

Attachment: Screen Recording 2022-09-01 at 19.11.00.mov

Attached a recording of the observed behaviour (watch with care if photosensitive)

Comment 2

[Dão Gottwald [:dao]]

This is basically working as expected. "Nightly theme" ends up falling back to "System theme" because colorways don't mandate a content color scheme. There are plans to remove the "Nightly theme" option from about:preferences because it's confusing.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #2)

There are plans to remove the "Nightly theme" option from about:preferences because it's confusing.

Since we don't have a bug filed on this yet, I guess we can just use this one.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1788822 - Simplify color-scheme content override pref to only be [dark, light, auto]. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edaed3aeb0f9
Simplify color-scheme content override pref to only be [dark, light, auto]. r=emilio,fluent-reviewers,extension-reviewers,robwu,flod

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/edaed3aeb0f9