1788860 - Crash in [@ mozilla::ipc::MessageChannel::~MessageChannel | mozilla::net::PSocketProcessChild::~PSocketProcessChild]

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Crash report: https://crash-stats.mozilla.org/report/index/3f9c9901-711c-47f5-b2a6-449b40220902

MOZ_CRASH Reason: MOZ_CRASH(MessageChannel destroyed without being closed (mChannelState == ChannelConnected).)

Top 6 frames of crashing thread:

0 XUL mozilla::ipc::MessageChannel::~MessageChannel ipc/glue/MessageChannel.cpp:509
1 XUL mozilla::net::PSocketProcessChild::~PSocketProcessChild ipc/ipdl/PSocketProcessChild.cpp:129
2 XUL mozilla::net::SocketProcessImpl::~SocketProcessImpl netwerk/ipc/SocketProcessImpl.cpp:35
3 XUL XRE_InitChildProcess toolkit/xre/nsEmbedFunctions.cpp:745
4 plugin-container main ipc/app/MozillaRuntimeMain.cpp:96
5 None @0x0000000104fd5088 

Crashes started with build 20220901095452
Changelog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af1fc1e6eb24573a5ebad1754b9d4917e934a5f9&tochange=9b193eeae94e203f831a59eb823de3de73ad3860

Comment 1

[Kershaw Chang [:kershaw]]

I think this is not a regression, since the regression range seems not possible to cause this.
Moreover, there is no change to socket process code recently.
bwc, are you aware of any recent change at WebRTC side that could cause this?
Thanks.

Comment 2

[Kershaw Chang [:kershaw]]

The crash rate seems not really high, so I'd change the severity to s3.

Comment 3

[Kershaw Chang [:kershaw]]

Put this in our review queue to get this fixed soon.

Comment 4

[Kershaw Chang [:kershaw]]

I think this is a long standing issue, not regression.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1788860 - Always close IPC channel in SocketProcessChild::CleanUp, r=#necko

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd1199f8bb58
Always close IPC channel in SocketProcessChild::CleanUp, r=necko-reviewers,dragana

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cd1199f8bb58