1788905 - "failed to parse line" error in ShutdownLeaks shouldn't include the failing line

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew McCreight [:mccr8]]

As seen in bugs like bug 1788847, bug 1788848, bug 1773816, bug 1630111 and others, including the actual text of the line that failed to parse in the error message means that each failure will get its own bug filed. The failures seem to happen because multiple threads are writing to the log at the same time, so every failure will have different text. It is still important to know what the failing line is, so it could be printed out as an INFO after the error.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1788905 - Don't include failing line when ShutdownLeaks fails to parse.

This failure happens when multiple threads write to the log at the same
time, so every error will be different. Printing the line as an info
will make these failures easier to classify on TreeHerder.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb1dfc5ceaf
Don't include failing line when ShutdownLeaks fails to parse. r=ahal

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/abb1dfc5ceaf