Convert View Source toolkit actors from JSMs to ESMs
Categories
(Toolkit :: View Source, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
Details
(Whiteboard: [esmification-timeline])
Attachments
(1 file)
The three actors I'm thinking of converting are:
- https://searchfox.org/mozilla-central/rev/25ec642ed33ca83f25e88ec0f9f27e8ad8a29e24/toolkit/actors/ViewSourceChild.jsm
- https://searchfox.org/mozilla-central/rev/25ec642ed33ca83f25e88ec0f9f27e8ad8a29e24/toolkit/actors/ViewSourcePageChild.jsm
- https://searchfox.org/mozilla-central/rev/25ec642ed33ca83f25e88ec0f9f27e8ad8a29e24/toolkit/actors/ViewSourcePageParent.jsm
|
Assignee | |
Comment 1•2 years ago
|
||
This was taken care of mostly by automation via the ./mach esmify script, but I
had to update the ActorManagerParent.jsm by hand to refer to the new ESMs.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/193c31e135cc Convert View Source toolkit JSWindowActors from JSMs to ESMs. r=nchevobbe
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)
Created attachment 9292852 [details]
Bug 1788933 - Convert View Source toolkit JSWindowActors from JSMs to ESMs. r?nchevobbe!This was taken care of mostly by automation via the ./mach esmify script, but I
had to update the ActorManagerParent.jsm by hand to refer to the new ESMs.
Did you run the ./mach esmify --imports . --prefix=toolkit/actors/ command as well? If the first command didn't change it, I'd have expected that one to update it.
|
|
Assignee | |
Comment 5•2 years ago
|
||
I did, yes - but still found this few leftovers that I needed to update manually. ¯_(ツ)_/¯
Description
•