1788953 - While showSearchTerms is true, opening a background tab to a default SERP won't show the search terms when the tab is focused

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[James Teow [:jteow]]

When a user highlights one of the auto-suggested results from the Urlbar and does a search in a new background tab, going to that tab won't show the search term in the Urlbar.

That code path doesn't set the user typed value.

Comment 1

[James Teow [:jteow]]

The proposed approach for this as discussed with :adw is:

1. Save the originalURI on the browser custom element upon loading a new page. This URI should be the first URI loaded for the page.
2. Rework UrlbarInput.setURI to no longer require the originalURI to be passed in, and instead the additional params (beyond the URI) will be an object with properties. The searchTerms check in setURI will instead reference the selected browsers originalURI.
3. Add tests that check the search term is shown in background generated tabs.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1788953 - Part 1: Add originalURI to browser-custom-element - r?adw

Comment 3

[James Teow [:jteow]]

Attachment: Bug 1788953 - Part 2: Use cached originalURI in setURI - r?adw

Depends on D157485

Comment 4

[James Teow [:jteow]]

Attachment: Bug 1788953 - Part 3: Modify revert test and add new background tab test - r?adw

Depends on D157486

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cda7550cf2b
Part 1: Add originalURI to browser-custom-element - r=adw
https://hg.mozilla.org/integration/autoland/rev/12e98c774744
Part 2: Use cached originalURI in setURI - r=adw
https://hg.mozilla.org/integration/autoland/rev/b20236791eb0
Part 3: Modify revert test and add new background tab test - r=adw

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7cda7550cf2b
https://hg.mozilla.org/mozilla-central/rev/12e98c774744
https://hg.mozilla.org/mozilla-central/rev/b20236791eb0

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified as part of the preliminary testing for the Persist Search term in address bar.