[wpt-sync] Sync PR 35770 - Always do unforgiving parsing for all selectors inside @supports
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 35770 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/35770
Details from upstream follow.
Byungwoo Lee <blee@igalia.com> wrote:
Always do unforgiving parsing for all selectors inside @supports
To detect invalid selector usage, always do unforgiving parsing for
all selectors inside @support according to the csswg issue resolution:
https://github.com/w3c/csswg-drafts/issues/7280#issuecomment-1143852187Bug: 1358953, 1359396
Change-Id: If203c8d6124edbf67b1ebf0f58cf1a01b31c90a6
Reviewed-on: https://chromium-review.googlesource.com/3872106
WPT-Export-Revision: ee4529098b5b8c8a1046cfc6af99c82dee32e579
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=839b535625bf2c10e6cd292d893a166504fc0fd0
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 4 subtests
Status Summary
Firefox
OK : 1
PASS: 1
FAIL: 4
Chrome
OK : 1
FAIL: 5
Safari
OK : 1
FAIL: 5
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-conditional/at-supports-selector-detecting-invalid-in-forgiving-argument.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-conditional/js/CSS-supports-selector-detecting-invalid-in-forgiving-argument.html [wpt.fyi]
- Invalid selector can be detected with CSS.supports() even if it is dropped by forgiving parsing:
FAIL(Chrome:FAIL, Safari:FAIL) - :is(), :where() or :has() always fails without argument:
FAIL(Chrome:FAIL, Safari:FAIL) - Some pseudo elements always fail inside :is(), :where(), :has():
FAIL(Chrome:FAIL, Safari:FAIL)
- Invalid selector can be detected with CSS.supports() even if it is dropped by forgiving parsing:
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a03a32845177 [wpt PR 35770] - Parsing all selectors unforgiving way for @supports selector(), a=testonly https://hg.mozilla.org/integration/autoland/rev/1475651f2686 [wpt PR 35770] - Update wpt metadata, a=testonly
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a03a32845177
https://hg.mozilla.org/mozilla-central/rev/1475651f2686
Description
•