1789114 - Wrap attribute broken for emulated -moz-box

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Shane Hughes [:aminomancer]]

Attachment: An example of the bug

Since the changes in bug 1784265, the send-to-device client buttons in the "Send tab to device" subview (sign in to FxA, sync a device and give it a long name, open app menu, click profile button, click Send tab to device) are not wrapping as expected. The labels overflow without an ellipsis either. They used to wrap onto multiple lines. You can also test this by just adding wrap="true" to any toolbarbutton in a panel and making its label long enough to overflow. I also attached a picture of an example. (Bisection yielded this pushlog btw)

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: How it looked in 103.0a1

(Also here's an image of how it looked before)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784265

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1789114 - Use block rather than -moz-box display for subview button text. r=aminomancer

Some context on why this used to work:

When wrap=true, we add inline text to the <label>. It has a
-moz-box display, so we wrap their kids in a
::-moz-xul-anonymous-block:

https://searchfox.org/mozilla-central/rev/39a48ce1b2b20a004dfa364d0587164f838b62b0/layout/base/nsCSSFrameConstructor.cpp#9882-9908

Before my patch, flex attributes did affect this anonymous block, but
-moz-box-flex set from CSS didn't, which was inconsistent, so I chose
the CSS behavior. The old flex attribute behavior we could get by
inheriting -moz-box-flex here:

https://searchfox.org/mozilla-central/rev/39a48ce1b2b20a004dfa364d0587164f838b62b0/layout/style/res/ua.css#210

But given modern flex / grid items don't have that, it seems bad to
further diverge. Instead, since we're relying on block behavior
implicitly anyways, do that explicitly instead, which works for both.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdf7161e6f07
Use block rather than -moz-box display for subview button text. r=aminomancer

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cdf7161e6f07

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9293003 [details]
Bug 1789114 - Use block rather than -moz-box display for subview button text. r=aminomancer

Beta/Release Uplift Approval Request

• User impact if declined: in some locales text that's supposed to wrap might get clipped instead.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 for example
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple css change.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 106.0a1 (2022-09-05).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9293003 [details]
Bug 1789114 - Use block rather than -moz-box display for subview button text. r=aminomancer

Approved for 105.0b8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/271d2af7688b

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in Beta 105.0b8.