Replace hardcoded `firefox` and `browser` instances in MSIX packaging
Categories
(Firefox :: Installer, enhancement, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: rjl, Assigned: rjl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is to facilitate repackaging Thunderbird as an MSIX.
mozbuild/mozbuild/repackaging/msix.py contains a couple of places where firefox is hardcoded:
https://searchfox.org/mozilla-central/rev/39a48ce1b2b20a004dfa364d0587164f838b62b0/python/mozbuild/mozbuild/repackaging/msix.py#479,529
These can be replaced with the app_name variable: https://searchfox.org/mozilla-central/rev/39a48ce1b2b20a004dfa364d0587164f838b62b0/python/mozbuild/mozbuild/repackaging/msix.py#286
mozbuild/mozbuild/mach_commands.py will need to accept a app_name argument, to pass along to mozbuild.repackage.msix.repackage_msix().
mozbuild/mozbuild/mach_commands.py sets up template and branding variables that are passed to mozbuild.repackage.msix.repackage_msix(). These are both hardcoded the browser directory. I'm proposing adding a build_app argument that from which both of these variables can be derived.
There will be small changes to each applications mozharness repackage configs to set the values and to gecko_taskgraph.transforms.repackage to add the arguments. The mozharness repackage configs for both Firefox and Thunderbird have a package-name value which will be used for the app_name argument. A build-app value will need to be added.
|
||
Comment 1•2 years ago
|
||
rjl: I'm happy to see almost any reasonable generalization of this work land. Flag me or :bhearsum for reviews.
|
Assignee | |
Comment 2•2 years ago
|
||
These are changes to decouple the MSIX repackaging from Firefox/browser and
allow repackaging Thunderbird.
Arguments added to the mach command have defaults that are appropriate for
Firefox. Thunderbird CI jobs will set these arguments in a comm_taskgraph
transform.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by thunderbird@calypsoblue.org: https://hg.mozilla.org/integration/autoland/rev/26e37484f9ee Extend MSIX repackaging to work with other products. r=nalexander
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•