178919 - News filter with action of Watch Thread doesn't work

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[scottputterman]

Using 11/6 build.  I set up a news filter where the action is Watch Thread.  I
see messages that have the watch icon, but when I switch to the View Watched
Threads with Unread messages view, nothing shows up.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

when we add a hdr to a thread, check if it has the watch/ignored flags set.
Also, fix handling of new watched threads with unread getting added to open
view.

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 105490 [details] [diff] [review]
proposed fix

sr=sspitzer

should we enable watch / ignore for mail filters?

Comment 3

[David :Bienvenu]

I guess we can, though I don't think it makes a lot of sense unless we enable
the commands for watching/ignoring mail threads. Cavin, can I get an r=? thx.

Comment 4

[(not reading, please use [e-mail] instead)]

It's fine with me if we don't.  (they feel like news things anyways)

should we remove the action code in imapfolder and parsemailbox then that
handles those actions?

Comment 5

[David :Bienvenu]

they feel like news things, but people want them for mail (the canonical example
is mailing lists). We could turn on watch/ignore for mail, but we'd just have to
disable the keyboard shortcut for ignore for mail, because people were
accidentally ignoring mail. My opinion is that we should allow people to
watch/ignore mail messages, but not with the keyboard shortcuts. I suppose
people are going to want to do this with filters too - I dont' really know. I'd
leave the backend code as is, so if we decide to expose the ui (or let people do
it by hand in rules.dat), we can still do it.

Comment 6

[Cavin Song]

Comment on attachment 105490 [details] [diff] [review]
proposed fix

r=cavin.

Comment 7

[David :Bienvenu]

fix checked in.

Comment 8

[(not reading, please use [e-mail] instead)]

I'll move bienvenu's comments to another bug.

thanks for the info, david.

Comment 9

[(not reading, please use [e-mail] instead)]

bienvenu's comments spun off to bug 179033

Comment 10

[laurel]

OK uisng dec23 commercial trunk: win98, linux rh8.0, mac OS 10.2