Closed Bug 1789205 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35782 - [scroll-animations] Determine forced updates using style roots

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35782 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35782
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[scroll-animations] Determine forced updates using style roots

For forced style updates on a single element (e.g. getComputedStyle),
we try to avoid updating the style and layout-tree if we know that
the next call to UpdateStyleAndLayoutTree will not affect that element.
Figuring this out involves traversing the ancestor chain of the target
element, looking for dirty-flags and the like.

However, with the introduction of scroll-timelines, it is no longer
sufficient to traverse the ancestor chain, because the named timeline
lookup can reach previous siblings (and previous siblings of all
ancestors). We probably don't want to traverse all of those siblings,
so instead this CL suggests basing the optimization on whether or not
there is a style recalc/invalidation root in the ancestor chain.
This makes it possible to solve the problem of scroll-timelines/
siblings by checking the parent element of the style root against the
the parent of the target element.

Bug: 1317765
Change-Id: Ic13587ce7535da02aeb00699e29c26ee867eb249
Fixed: 1356493
Reviewed-on: https://chromium-review.googlesource.com/3859628
WPT-Export-Revision: e4e61eabdbc4e71697dc6212c0a489de2fcadeee

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b02b382bb0d7
[wpt PR 35782] - [scroll-animations] Determine forced updates using style roots, a=testonly
https://hg.mozilla.org/integration/autoland/rev/68f5e8542775
[wpt PR 35782] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b02b382bb0d7
https://hg.mozilla.org/mozilla-central/rev/68f5e8542775

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.