1789221 - [wpt-sync] Sync PR 35726 - [scroll-animations] NodeLayoutUpgrade considers interleaving roots only

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35726 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35726
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[scroll-animations] NodeLayoutUpgrade considers interleaving roots only

During forced style updates (e.g. getComputedStyle), we currently have
logic which tries to find ComputedStyles above the target node which
depend on size-container-queries. This does not work anymore for the
named scroll-timelines, because we also need to take into account
the preceding siblings of all inclusive ancestors.

Since doing all of that traversal is not desirable, this CL suggests
to instead simplify the logic such that we do layout upgrades whenever
the target element is inside a container. This means we'll do more
layout upgrades than before, but there really isn't a (better)
alternative.

Bug: 1317765
Change-Id: Id23a483761b1a30e6dfc37f45253c6a2740d41c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865318
Auto-Submit: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1043140}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fe7e65b09e2d69253084573560c1b3aece0bc0a

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-animations/css/scroll-timeline-in-container-query.html [wpt.fyi]
  • Timeline appearing via container queries: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f672fb647e5
[wpt PR 35726] - [scroll-animations] NodeLayoutUpgrade considers interleaving roots only, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b565f3fc6ae9
[wpt PR 35726] - Update wpt metadata, a=testonly

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5f672fb647e5
https://hg.mozilla.org/mozilla-central/rev/b565f3fc6ae9