1789226 - Zap gradient border is missing from Tab Pickup cards

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Sarah Clements [:sclements]]

Attachment: Screenshot 2022-09-05 at 11.26.58.png

I think this might be a regression from bug 1784902. It now lacks the border on nightly (I checked the commit prior to when Sam's landed on autoland).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784902

Comment 2

[Ray Fambro]

I know that this is a minor cosmetic bug, but I do think it makes a pretty big difference in the UI. Would love to get this fixed if we can.

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Sarah Clements [:sclements] from comment #0)

I think this might be a regression from bug 1784902. It now lacks the border on nightly (I checked the commit prior to when Sam's landed on autoland).

That does seem plausible. The ::before element has z-index: -1 which seems to now be causing it to disappear. Note that if you remove the z-index property the zap border appears again, but then the card content isn't clickable - which was the issue I had to fix when bug 1784902 got backed out.

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1789226 - Show zap gradient border for tab pickup cards. r=sfoster,sclements

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3052aae410d1
Show zap gradient border for tab pickup cards. r=sclements

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3052aae410d1

Comment 7

[Bogdan Maris, Desktop QA]

Reproduced the initial issue described in comment 0 using an old Nightly from 2022-09-05, verified that this issue is fixed using Firefox 106.0b2 on macOS 11, Windows 11, Ubuntu 20.04.