Closed Bug 1789249 Opened 4 years ago Closed 4 years ago

ESLint should ignore files listed in Generated.txt, and ESLint linter tests

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox106 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files)

Bug 1789249 - ESLint should ignore files listed in Generated.txt, and ESLint linter tests. r=mossop
48 bytes, text/x-phabricator-request
Details | Review
Bug 1789249 - For the linter ESLint tests ignore exclusions from the main .eslintignore. r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Running eslint in a raw format (via the ESLint command, not using mach), I noticed that we're not excluding files that are listed in Generated.txt.

We're also not excluding tools/lint/test/files which is a set of files used to test the linter output.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44fb0e3f3843 ESLint should ignore files listed in Generated.txt, and ESLint linter tests. r=mossop

https://hg.mozilla.org/mozilla-central/rev/44fb0e3f3843

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED

Backed out for causing mozlint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/630a8a9a4c637e3a4e72ee77d5f7c223a7d63205

Failure log: https://treeherder.mozilla.org/logviewer?job_id=389712679&repo=autoland&lineNumber=955

Status: RESOLVED → REOPENED
status-firefox106: fixed → ---
Flags: needinfo?(standard8)
Resolution: FIXED → ---
Attachment #9293137 - Attachment description: Bug 1789249 - ESLint should ignore files listed in Generated.txt, and ESLint linter tests. r?Mossop → Bug 1789249 - ESLint should ignore files listed in Generated.txt, and ESLint linter tests. r=mossop
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8182b2c18b62 ESLint should ignore files listed in Generated.txt, and ESLint linter tests. r=mossop https://hg.mozilla.org/integration/autoland/rev/ddb8b37dd26f For the linter ESLint tests ignore exclusions from the main .eslintignore. r=linter-reviewers,ahal

https://hg.mozilla.org/mozilla-central/rev/8182b2c18b62
https://hg.mozilla.org/mozilla-central/rev/ddb8b37dd26f

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: