1789311 - bootstrap.py fails when Powershell is installed on a Linux system

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Alex Huang]

Attachment: bootstrap.py

Steps to reproduce:

• download and install Powershell for Linux (from Github)
• download and run the bootstrap.py file

Actual results:

when run python3 throws an error
File "/home/teapot/bootstrap.py", line 284, in add_microsoft_defender_antivirus_exclusions
ctypes.windll.shell32.ShellExecuteW(None, "runas", powershell_exe, command, None, 0)
AttributeError: module 'ctypes' has no attribute 'windll'

Expected results:

bootstrap.py should not have attempted to call ctypes.windll as this function is native to Windows and is not available on Linux.

Comment 1

[Alex Hochheiden [:ahochheiden]]

Interesting, I didn't know PowerShell was available outside of Windows. Pretty easy fix, I'll take care of it.

Comment 2

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1789311 - Only attempt to add Microsoft Defender Antivirus Exclusion on Windows r?#build

Since PowerShell is also available on Linux, checking for that is not
sufficient. We must first check if we're on Windows, and if we're not,
return early.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/054c56d730df
Only attempt to add Microsoft Defender Antivirus Exclusion on Windows r=firefox-build-system-reviewers,nalexander

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/054c56d730df