1789346 - [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/subprojects/zlib-1.2.11/gzread.c:35:15: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Status: NEW

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2022-09-06T04:36:21.097Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/subprojects/zlib-1.2.11/gzread.c:35:15: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:36:21.097Z] [osmesa-src 0.2.0]         ret = read(state->fd, buf + *have, get);
[task 2022-09-06T04:36:21.097Z] [osmesa-src 0.2.0]               ^

So the problem here is:

• osmesa-src doesn't use system zlib on mac (even with an explicit method: "system", I haven't dug deeper), which makes it download it per the instructions in https://github.com/servo/osmesa-src/blob/master/mesa-src/subprojects/zlib.wrap
• the instructions there pull a mesonbuild script that doesn't set a specific C standard to use, so the one set in https://github.com/servo/osmesa-src/blob/master/mesa-src/meson.build is used (C99)
• the zlib source is ostensibly not C99. To the point of using old K&R style function declarations that also trigger warnings. It also doesn't include unistd.h, which makes functions such as read undeclared.
• clang 15, in C99 mode, now rejects undeclared functions by default.

Comment 1

[Mike Hommey [:glandium]]

Past that error, we hit those:

[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] FAILED: src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_arit.c.o 
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] /builds/worker/fetches/clang/bin/clang -fuse-ld=/builds/worker/fetches/cctools/bin/x86_64-apple-darwin-ld -target x86_64-apple-darwin -mmacosx-version-min=10.7 --rtlib=compiler-rt --sysroot /builds/worker/fetches/MacOSX11.3.sdk -Wno-error=implicit-function-declaration -Isrc/gallium/auxiliary/libgallium.a.p -Isrc/gallium/auxiliary -I../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary -Isrc/loader -I../../../../../../../vendor/osmesa-src/mesa-src/src/loader -I../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/include -Isrc -I../../../../../../../vendor/osmesa-src/mesa-src/src -Iinclude -I../../../../../../../vendor/osmesa-src/mesa-src/include -I../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/util -Isrc/compiler/nir -I../../../../../../../vendor/osmesa-src/mesa-src/src/compiler/nir -Isrc/util -I../../../../../../../vendor/osmesa-src/mesa-src/src/util -Isubprojects/zlib-1.2.11 -I../../../../../../../vendor/osmesa-src/mesa-src/subprojects/zlib-1.2.11 -I/builds/worker/fetches/clang/include -fvisibility=hidden -Xclang -fcolor-diagnostics -pipe -Wall -Winvalid-pch -std=c99 -O2 -g '-DPACKAGE_VERSION="20.3.0-devel"' '-DPACKAGE_BUGREPORT="https://gitlab.freedesktop.org/mesa/mesa/-/issues"' -DBUILDING_MESA -DUSE_ELF_TLS -DENABLE_ST_OMX_BELLAGIO=0 -DENABLE_ST_OMX_TIZONIA=0 -DEGL_NO_X11 -DENABLE_SHADER_CACHE -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE -DHAVE_FUNC_ATTRIBUTE_CONST -DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_MALLOC -DHAVE_FUNC_ATTRIBUTE_PURE -DHAVE_FUNC_ATTRIBUTE_UNUSED -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE_FUNC_ATTRIBUTE_WEAK -DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_NORETURN -DHAVE_FUNC_ATTRIBUTE_VISIBILITY -DHAVE_UINT128 -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS -DHAVE_SYS_SYSCTL_H -DHAVE_XLOCALE_H -DHAVE_DLFCN_H -DHAVE_EXECINFO_H -DHAVE_SYS_SHM_H -DHAVE_CET_H -DHAVE_STRTOF -DHAVE_MKOSTEMP -DHAVE_TIMESPEC_GET -DHAVE_FLOCK -DHAVE_STRTOK_R -DHAVE_POSIX_MEMALIGN -DHAVE_DIRENT_D_TYPE -DHAVE_STRTOD_L -DHAVE_DLADDR -DHAVE_ZLIB -DHAVE_PTHREAD -DLLVM_AVAILABLE '-DMESA_LLVM_VERSION_STRING="15.0.0"' -DLLVM_IS_SHARED=1 -Qunused-arguments -D__STDC_LIMIT_MACROS -D_GNU_SOURCE -D__STDC_FORMAT_MACROS -D__STDC_CONSTANT_MACROS -MD -MQ src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_arit.c.o -MF src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_arit.c.o.d -o src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_arit.c.o -c ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:428:18: warning: call to undeclared function 'LLVMConstFSub'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]           return LLVMConstFSub(bld->one, a);
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]                  ^
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:428:18: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'LLVMValueRef' (aka 'struct LLVMOpaqueValue *') [-Wint-conversion]
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]           return LLVMConstFSub(bld->one, a);
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:516:16: warning: call to undeclared function 'LLVMConstFAdd'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]          res = LLVMConstFAdd(a, b);
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0]                ^
[task 2022-09-06T04:59:49.719Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:516:14: error: incompatible integer to pointer conversion assigning to 'LLVMValueRef' (aka 'struct LLVMOpaqueValue *') from 'int' [-Wint-conversion]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          res = LLVMConstFAdd(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]              ^ ~~~~~~~~~~~~~~~~~~~
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:852:16: warning: call to undeclared function 'LLVMConstFSub'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          res = LLVMConstFSub(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]                ^
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:852:14: error: incompatible integer to pointer conversion assigning to 'LLVMValueRef' (aka 'struct LLVMOpaqueValue *') from 'int' [-Wint-conversion]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          res = LLVMConstFSub(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]              ^ ~~~~~~~~~~~~~~~~~~~
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:1017:16: warning: call to undeclared function 'LLVMConstFMul'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          res = LLVMConstFMul(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]                ^
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:1017:14: error: incompatible integer to pointer conversion assigning to 'LLVMValueRef' (aka 'struct LLVMOpaqueValue *') from 'int' [-Wint-conversion]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          res = LLVMConstFMul(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]              ^ ~~~~~~~~~~~~~~~~~~~
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0] ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_arit.c:1322:17: warning: call to undeclared function 'LLVMConstFDiv'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]          return LLVMConstFDiv(a, b);
[task 2022-09-06T04:59:49.720Z] [osmesa-src 0.2.0]                 ^

These functions were removed, as per https://github.com/llvm/llvm-project/blob/release/15.x/llvm/docs/ReleaseNotes.rst#changes-to-the-c-api

Comment 2

[Mike Hommey [:glandium]]

And after that:

[task 2022-09-06T06:02:57.422Z]   ../../../../../../../vendor/osmesa-src/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_init.c:52:10: fatal error: 'llvm-c/Transforms/Coroutines.h' file not found
[task 2022-09-06T06:02:57.422Z]   #include <llvm-c/Transforms/Coroutines.h>
[task 2022-09-06T06:02:57.422Z]            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 3

[Mike Hommey [:glandium]]

And after all this, we get a crash in the webrender-macos-release task, without a backtrace despite RUST_BACKTRACE being set to full.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Mike Hommey [:glandium]]

Attachment: This is how far I got.