Update OTS to 8.2.2
Categories
(Core :: Graphics: Text, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: RyanVM, Assigned: jfkthame)
References
Details
(Whiteboard: [third-party-lib-audit][gfx-noted])
Attachments
(5 files)
+++ This bug was initially created as a clone of Bug #1748352 +++
Version 8.2.2
- Fix ots-side-by-side.1 man page (#240)
- Relax requirements for axis.axisNameID (#210)
- Exit early if decompressed size exceeds OTSStream's size limit (#244)
- Fix binary builds
|
Reporter | |
Comment 1•2 years ago
|
||
Jonathan, a new check was added to a function that we patch in the RLBox code:
https://github.com/khaledhosny/ots/blob/main/src/ots.cc#L534
It looks to me like we might want to add that to RLBoxWOFF2Host.cpp as well? Maybe in the Woff2SizeValidator function?
|
Assignee | |
Comment 2•2 years ago
|
||
Yeah, I suppose we should hook this up. (It's not functionally critical, just an early exit opportunity.) It looks like we'll need to add an override of the new (pure-virtual) size() method to our OTSStream implementation, anyhow, before it'll even compile (AFAICS).
Are you happy to do this or would you like me to pick it up?
|
|
Reporter | |
Comment 3•2 years ago
|
||
If you have the cycles to do so, go for it.
|
|
Assignee | |
Comment 4•2 years ago
|
||
OK, will do. (FWIW, I'm hoping there'll be a further OTS update soon, actually, once Khaled has had time to review https://github.com/khaledhosny/ots/pull/247.)
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
|
Assignee | |
Comment 6•2 years ago
|
||
Depends on D156857
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D156858
|
|
Assignee | |
Comment 8•2 years ago
|
||
Depends on D156859
|
|
Assignee | |
Comment 9•2 years ago
|
||
Depends on D156860
|
|
Assignee | |
Comment 10•2 years ago
|
||
|
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 11•2 years ago
|
||
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d72ca3bcd782 Update ots-rlbox.patch to apply to OTS 8.2.2. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/142c153da6e3 Update OTS source to 8.2.2. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/0215f5326a14 Implement the size() method in our OTSStream subclass. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/1ca9f4524d41 Add check of the output-stream size limit in RLBoxWOFF2Host.cpp. r=RyanVM https://hg.mozilla.org/integration/autoland/rev/8225d0c430de Cherry-pick https://github.com/khaledhosny/ots/pull/247/commits/2dc0c5eca9da5d430b8012028f69c0ffb65fada5 to fix build failure in ots/tests. r=RyanVM
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d72ca3bcd782
https://hg.mozilla.org/mozilla-central/rev/142c153da6e3
https://hg.mozilla.org/mozilla-central/rev/0215f5326a14
https://hg.mozilla.org/mozilla-central/rev/1ca9f4524d41
https://hg.mozilla.org/mozilla-central/rev/8225d0c430de
Description
•