Closed Bug 1789441 Opened 2 years ago Closed 2 years ago

CSS Regression: appearance changes for input number spinner no longer apply

Categories

(Core :: CSS Parsing and Computation, defect)

Firefox 103
defect

Tracking

()

RESOLVED DUPLICATE of bug 1786521

People

(Reporter: Kfilz, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

I have a CodeSandbox example to use, only targeting Firefox, because each browser seems to need spinners to be dealt with in their own way.
https://codesandbox.io/s/hungry-kare-x6rsws?file=%2Findex.html

Actual results:

input labeled arrow shows the spinner arrows
input labeled none shows none
input labeled chrome-like shows spinner arrows only when focused or hovered
input labeled dynamic has a toggle button that hides and shows the spinner

both dynamic and chrome-like inputs have their background change to red to assert that other changes work and that the appearance change should apply

Expected results:

input labeled arrow shows the spinner arrows
input labeled none shows none
input labeled chrome-like does not show spinner arrows at all
input labeled dynamic had a toggle button does not toggle the spinner

both dynamic and chrome-like inputs have their background change to red to assert that other changes work and that the appearance change should apply, but don't

For the "fun" of it, I ran a git bisect in the FF source code under Linux, which spat back https://phabricator.services.mozilla.com/rMOZILLACENTRAL1ce090cbb73bbab346cf826c83c92c7d5408b31a as the offending commit. Still effects nightlies and trunk.

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → CSS Parsing and Computation
Product: Firefox → Core

:Kfilz, I'm assuming "actual" and "expected" are flipped here?

Flags: needinfo?(Kfilz)
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE

(In reply to Kyle Filz from comment #0)

For the "fun" of it, I ran a git bisect in the FF source code under Linux, which spat back https://phabricator.services.mozilla.com/rMOZILLACENTRAL1ce090cbb73bbab346cf826c83c92c7d5408b31a as the offending commit. Still effects nightlies and trunk.

for the record, mozregression can save you a lot of pain rebuilding. Thanks for the report! I had already a fix up for review :)

(In reply to David Shin[:dshin] from comment #2)

:Kfilz, I'm assuming "actual" and "expected" are flipped here?

facepalm.png

Yup, I'd say I need more coffee, but caffeine does jack for me at best.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

for the record, mozregression can save you a lot of pain rebuilding. Thanks for the report! I had already a fix up for review :)

Good to know for next time, though it only took me about 16 builds at about 25m each to pin it down, until the last 10 where is really started to speed up due to not all ways having to toss all the cached stuff.

Flags: needinfo?(Kfilz)
You need to log in before you can comment on or make changes to this bug.