1789517 - [rust 1.64] error: named argument `root` is not used by name

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Mike Hommey [:glandium]]

[task 2022-09-06T22:07:15.138Z] 22:07:15     INFO -  error: named argument `root` is not used by name
[task 2022-09-06T22:07:15.138Z] 22:07:15     INFO -    --> toolkit/components/places/bookmark_sync/src/store.rs:95:13
[task 2022-09-06T22:07:15.138Z] 22:07:15     INFO -     |
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -  88 |                            WHERE guid = '{0}')
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -     |                                           - this formatting argument uses named argument `root` by position
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -  ...
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -  95 |             root = dogear::ROOT_GUID,
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -     |             ^^^^ this named argument is referred to by position in formatting string
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -     |
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -     = note: `-D named-arguments-used-positionally` implied by `-D warnings`
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -  help: use the named argument by name to avoid ambiguity
[task 2022-09-06T22:07:15.139Z] 22:07:15     INFO -     |
[task 2022-09-06T22:07:15.140Z] 22:07:15     INFO -  88 |                            WHERE guid = '{root}')
[task 2022-09-06T22:07:15.140Z] 22:07:15     INFO -     |                                           ~~~~
[task 2022-09-06T22:07:15.140Z] 22:07:15     INFO -  warning: ignoring -C extra-filename flag due to -o flag
[task 2022-09-06T22:07:15.140Z] 22:07:15     INFO -  warning: `bookmark_sync` (lib) generated 1 warning
[task 2022-09-06T22:07:15.140Z] 22:07:15     INFO -  error: could not compile `bookmark_sync` due to previous error; 1 warning emitted

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1789517 - Use named format argument by name instead of positionally.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d5db9ebf21
Use named format argument by name instead of positionally. r=markh

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/51d5db9ebf21