1789560 - [s390x] error: typedef redefinition with different types ('__float_t' (aka 'float') vs 'double')

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Mike Hommey [:glandium]]

ERROR -  /builds/worker/checkouts/gecko/modules/fdlibm/src/math_private.h:36:21: error: typedef redefinition with different types ('__float_t' (aka 'float') vs 'double')
INFO -  typedef __float_t   float_t;
INFO -                      ^
INFO -  /builds/worker/fetches/sysroot-s390x-linux-gnu/usr/include/math.h:152:16: note: previous definition is here
INFO -  typedef double float_t;
INFO -                 ^
INFO -  1 error generated.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1595259

:arai, since you are the author of the regressor, bug 1595259, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Tooru Fujisawa [:arai]]

what does typedef double float_t imply in the system?
what are the size of float and double, and what's the expectation for float and float_t?

I think, the error itself can be avoided by just removing the typedef __float_t float_t; line, given there's no consumer of float_t itself.
my concern is __float_t, that's used by the following:

https://searchfox.org/mozilla-central/rev/fb95a6dc3db347664f89998ab5843da4167c5140/modules/fdlibm/src/math_private.h#638

sizeof(__float_t) == sizeof(long double) ? irintf(x) :	\

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1789560 - Do not define unused float_t type in fdlibm. r?glandium!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1595259

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3c8c01f292b
Do not define unused float_t type in fdlibm. r=glandium

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c3c8c01f292b