Closed Bug 1789585 Opened 2 years ago Closed 1 year ago

FS: Implement InitOrigin and GetUsageForOrigin

Categories

(Core :: DOM: File, task, P2)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: janv, Assigned: jjalkanen)

References

Details

Attachments

(11 files, 2 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

These methods are currently unimplemented. We can't do the switch to <profile>/storage (from <profile>/opfs-storage) without it.

Assignee: nobody → jjalkanen
Attachment #9295056 - Attachment description: WIP: Bug 1789585 - Implement InitOrigin for fs::QuotaClient. → Bug 1789585 - Implement InitOrigin and GetUsageForOrigin for fs::QuotaClient. r=#dom-storage
Status: NEW → ASSIGNED

Depends on D163631

Stub is fully implemented together with fs::QuotaClient::GetUsage.

Depends on D163631

  • Documentation added to FileSystemFileManager header
  • Method to get the database path without creating it added
  • Method to get a file for entryId without creating it added
  • FS_QUOTA_MANAGEMENT_ENABLED flag moved to GetDirectoryForOrigin header
  • GetDirectoryForOrigin header added to where the flag is used
Attachment #9306295 - Attachment description: Bug 1789585 - Allow external linkage of file system database version getter. r=#dom-storage → Bug 1789585 - Replace custom schema version getter with existing implementation. r=#dom-storage

TestFileSystemDataManager.cpp invented a way to access QuotaManager in a gtest.
New tests are being added which need the same infrastructure so this patch
creates a base class which can be reused by multiple gtests.

Depends on D165320

Comment on attachment 9310108 [details]
Bug 1789585 - Introduce QuotaManagerDependencyFixture; r=#dom-storage

Revision D165678 was moved to bug 1801364. Setting attachment 9310108 [details] to obsolete.

Attachment #9310108 - Attachment is obsolete: true
Pushed by jjalkanen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e78bbdc56e6
Add file system as valid quota client type. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/090dac54564e
Add stub for file usage update in file system database manager. r=dom-storage-reviewers,jesup,janv
https://hg.mozilla.org/integration/autoland/rev/aa2045b420b6
Clean up FileSystemFileManager. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/afb4fa3374b7
Separate quota manager setup to test helper. r=dom-storage-reviewers,janv
Keywords: leave-open
Pushed by jjalkanen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/851c3c02927c
Test FileSystemQuotaClient. r=dom-storage-reviewers,jesup,janv
https://hg.mozilla.org/integration/autoland/rev/9c932a57f605
Replace custom schema version getter with existing implementation. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/024b8b4397c4
Replace forward declarations for return type with header includes. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/c28f4fa9d25e
Store total file size and if size is constant to usage schema. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/fa1fb3ee1eb6
Add file system as LockedGetUsage client. r=dom-storage-reviewers,janv
Pushed by jjalkanen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa5619933e00
Implement InitOrigin and GetUsageForOrigin for fs::QuotaClient. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e4f964cd806b
Bind and get booleans to and from ResultStatements. r=dom-storage-reviewers,janv
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9983b7af10d0
Implement InitOrigin and GetUsageForOrigin for fs::QuotaClient. r=dom-storage-reviewers,janv
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cf5ee4992ba
Bind and get booleans to and from ResultStatements. r=dom-storage-reviewers,janv

The failing test was fixed and the patch relanded.

Flags: needinfo?(jjalkanen)
Blocks: 1801364
Blocks: 1812243

Comment on attachment 9304517 [details]
Bug 1789585 - Rescan usages at QuotaClient initialization after crash. r=#dom-storage

Revision D162584 was moved to bug 1812243. Setting attachment 9304517 [details] to obsolete.

Attachment #9304517 - Attachment is obsolete: true
No longer blocks: 1812243
Depends on: 1812243
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: