1789590 - FS: Connect sync access handles to quota management

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

Writing to files was always done in the parent process, so all our supporting helpers reflect that. However, sync access handles need to be very fast, so we decided to do I/O mostly on the child side. We will need to add some new infrastructure and adjust existing helpers to be able to do the quota checks on the child side. One of the features should be pre-allocation of usage, so we won't need to synchronously talk with the parent process before each write operation.

Comment 1

[Jan Varga [:janv]]

I'll start adding separate bugs for this.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1789590 - FS: Connect sync access handles to quota management; r=#dom-storage

Depends on D157822

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1789590 - Implement and hook up FileSystemStreamCallbacks; r=#dom-storage

PFileSystemManager and PRemoteQuotaObject are independent top level protocols.
It can happen that the parent actor for PFileSystemManager is destroyed before
PRemoteQuotaObject parent actors are destroyed. So CanonicalQuotaObjects would
still exist after releasing the directory lock which would lead to assertions
in quota manager in the end. This patch prevents that by tracking parent actors
for PRemoteQuotaObject and releases the data manager when everything is
properly destroyed.

Depends on D164341

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a9685fe5878
Implement and hook up FileSystemStreamCallbacks; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/ef0d179e0aeb
FS: Connect sync access handles to quota management; r=dom-storage-reviewers,jesup

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4a9685fe5878
https://hg.mozilla.org/mozilla-central/rev/ef0d179e0aeb