Closed Bug 1789612 Opened 3 months ago Closed 3 months ago

38.41 - 20.78% tsvgx / tsvgx + 3 more (Linux, OSX) regression on Wed August 31 2022

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 --- fixed
firefox107 --- fixed

People

(Reporter: aesanu, Assigned: nical)

References

(Regression)

Details

(4 keywords)

Attachments

(1 file)

Perfherder has detected a talos performance regression from push 105858693e9a1ad58afa7309eb38f31ace500d2a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
38% tsvgx macosx1015-64-shippable-qr e10s fission stylo webrender 120.61 -> 166.93
34% tsvgx macosx1015-64-shippable-qr e10s fission stylo webrender 124.62 -> 166.47
33% tsvgx macosx1015-64-shippable-qr e10s fission stylo webrender-sw 145.87 -> 194.24
21% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender 186.13 -> 225.19
21% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender-sw 202.86 -> 245.02

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(nical.bugzilla)

Set release status flags based on info from the regressing bug 1787706

Sad. Probably means the tile size should be incresed only when the screen resolution is large (or the blob visible area). I'll back it out and experiment some more in a week when I come back from PTO.

Severity: -- → S3
Priority: -- → P3
Assignee: nobody → nical.bugzilla
Status: NEW → ASSIGNED
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/540dcf23e80e
Backed out changeset 105858693e9a for causing tsvgx regression. r=gfx-reviewers,jgilbert
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Does it need to be backed out in beta as well?

Yes I had missed that, thanks

Flags: needinfo?(nical.bugzilla)

Comment on attachment 9294910 [details]
Bug 1789612 - Backed out changeset 105858693e9a for causing tsvgx regression. r=#gfx-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Some things get faster some things get slower, we didn't expect things to get slower so we want to be on the safe side.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): backout of a simple and recent change.
  • String changes made/needed:
  • Is Android affected?: Yes
Attachment #9294910 - Flags: approval-mozilla-beta?

Comment on attachment 9294910 [details]
Bug 1789612 - Backed out changeset 105858693e9a for causing tsvgx regression. r=#gfx-reviewers

Approved for 106.0b3, thanks.

Attachment #9294910 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Pulsebot from comment #5)

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/540dcf23e80e
Backed out changeset 105858693e9a for causing tsvgx regression.
r=gfx-reviewers,jgilbert

== Change summary for alert #35450 (as of Thu, 22 Sep 2022 10:31:08 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
27% tsvgx macosx1015-64-shippable-qr e10s fission stylo webrender-sw 197.48 -> 144.76
26% tsvgx macosx1015-64-shippable-qr e10s fission stylo webrender 167.90 -> 124.47
21% tsvgx windows10-64-shippable-qr e10s fission stylo webrender 209.81 -> 165.19
21% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender 227.89 -> 180.86
20% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender-sw 247.09 -> 196.95
18% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender 226.83 -> 185.84

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35450

You need to log in before you can comment on or make changes to this bug.