Closed Bug 1789624 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35811 - [scroll-animations] Support view-timeline properties in the parser

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35811 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35811
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[scroll-animations] Support view-timeline properties in the parser

This CL adds parser support for the following properties:

  • view-timeline (shorthand)
  • view-timeline-axis
  • view-timeline-inset
  • view-timeline-name

The grammar of the view-timeline shorthand is at the time of writing
not correctly specified, so the implementation of that is based on
what seems reasonable. The accompanying test for the view-timeline
shorthand is marked as tentative.

Bug: 1344151
Change-Id: Icbb467223593ef2bc82daff7ef705c7402487539
Reviewed-on: https://chromium-review.googlesource.com/3871013
WPT-Export-Revision: c6a7f78413fb16877ec267868cdf159926d379fb

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 41 subtests

Status Summary

Firefox

OK : 7
PASS: 30
FAIL: 113

Chrome

OK : 7
PASS: 30
FAIL: 113

Safari

OK : 7
PASS: 30
FAIL: 113

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/css/view-timeline-axis-computed.html [wpt.fyi]
    • Property view-timeline-axis value 'initial': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'inherit': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'revert': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'vertical': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'horizontal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'block, inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'inline, block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'block, vertical, horizontal, inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-axis value 'inline, inline, inline, inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-axis property shows up in CSSStyleDeclaration enumeration: FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-axis property shows up in CSSStyleDeclaration.cssText: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-axis-parsing.html [wpt.fyi]
    • e.style['view-timeline-axis'] = "initial" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "inherit" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "unset" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "revert" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "vertical" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "horizontal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "block, inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "inline, block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "block, vertical, horizontal, inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-axis'] = "inline, inline, inline, inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-inset-computed.html [wpt.fyi]
    • Property view-timeline-inset value 'initial': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value 'inherit': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value 'revert': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px 2px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px 2em': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value 'calc(1px + 1em) 2px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px 2px, 3px 4px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px auto, auto 4px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px, 2px, 3px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value '1px 1px, 2px 3px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-inset value 'auto auto, auto auto': FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-inset property shows up in CSSStyleDeclaration enumeration: FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-inset property shows up in CSSStyleDeclaration.cssText: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-inset-parsing.html [wpt.fyi]
    • e.style['view-timeline-inset'] = "initial" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "inherit" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "unset" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "revert" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px 2px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px 2em" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "calc(1em + 1px) 2px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px 2px, 3px 4px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px auto, auto 4px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px, 2px, 3px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "1px 1px, 2px 3px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-inset'] = "auto auto, auto auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-name-computed.html [wpt.fyi]
    • Property view-timeline-name value 'initial': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'inherit': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'revert': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'none': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'foo': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'foo, bar': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'bar, foo': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'a, b, c, D, e': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'none, none': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline-name value 'a, b, c, none, d, e': FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-name property shows up in CSSStyleDeclaration enumeration: FAIL (Chrome: FAIL, Safari: FAIL)
    • The view-timeline-name property shows up in CSSStyleDeclaration.cssText: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-name-parsing.html [wpt.fyi]
    • e.style['view-timeline-name'] = "initial" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "inherit" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "unset" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "revert" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = " abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "abc " should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "aBc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "foo, bar" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "bar, foo" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "none, none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "a, none, b" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-shorthand.tentative.html [wpt.fyi]
    • e.style['view-timeline'] = "abcd" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "none block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "none inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "block block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "vertical block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "horizontal block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "a, b, c" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "a inline, b block, c vertical" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'abcd': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'none block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'none inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'inline block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'block block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'vertical block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'horizontal block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'a, b, c': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'a inline, b block, c vertical': FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:abc;view-timeline-axis:inline: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:a, b;view-timeline-axis:inline, block: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:none, none;view-timeline-axis:block, block: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f29d866908a
[wpt PR 35811] - [scroll-animations] Support view-timeline properties in the parser, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c749dd39eda7
[wpt PR 35811] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5f29d866908a
https://hg.mozilla.org/mozilla-central/rev/c749dd39eda7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.