1789718 - Remove the initial XPIProvider-based implementation of the Site Permissions addon type

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Along with the ongoing work for the new implementation based on a separate AddonManager Provider meant to only manage the Site Permissions addon type (Bug 1778959) we need to prepare to remove the initial XPIProvider based one (introduced by Bug 1737163).

As a side note to keep in mind while we are planning the removal:

• The XPIProvider-based implementation recognize an xpi as add-on type "sitepermission" based on the presence of the top level manifest key "site_permissions" otherwise fallback to "extensions" (see ExtensionData initializeAddonTypeAndID method)

• The ExtensionBlocklistMLBF defined in Blocklist.jsm determines which addon type should be checked by the addon blocklist based on the types exported by the XPIProvider (see kXPIAddonType lazy getter defined in Blocklist.jsm here), if the new implementation lands before we have removed the XPIProvider implementation this may be a part that we may split off into its own separate bugzilla issue and cover it in the same release where the new implementation is landing

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1789718 - Rename XPIProvider-based sitepermission addon type to sitepermission-deprecated. r?willdurand!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6097fabfae25
Rename XPIProvider-based sitepermission addon type to sitepermission-deprecated. r=willdurand

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6097fabfae25

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Removing this issue from Bug 1790621 blockers:

• The part of this issue that was blocking for Bug 1790621 (renaming the addon type associated to the deprecated XPIProvider-based implementation) has been landed in Nightly 107
• the rest of the deprecated implementation removal can be done as a separate followup and doesn't need to block Bug 1790621.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:rpl, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1789718 - Remove the deprecated XPIProvider-based implementation of the Site Permissions addon type. r?willdurand!

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1789718 - Remove from MIDIPermissionRequest error message pointing to obsolete docs related to deprecated siteperm addon type implementation. r?gsvelto!

Depends on D214246

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9499dbd6c9ab
Remove the deprecated XPIProvider-based implementation of the Site Permissions addon type. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/7f3daf307e3f
Remove from MIDIPermissionRequest error message pointing to obsolete docs related to deprecated siteperm addon type implementation. r=gsvelto

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9499dbd6c9ab
https://hg.mozilla.org/mozilla-central/rev/7f3daf307e3f