Closed Bug 1790072 Opened 2 years ago Closed 2 years ago

"Keep my Nightly colors" icon changes state for users with dark web appearance enabled

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
106 Branch
Iteration:
106.2 - Sept 5 - Sept 16
Tracking Status
firefox106 --- verified

People

(Reporter: asafko, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image Step 3

Prerequisites: enable dark theme and dark web appearance.

STR:

  1. Launch existing user onboarding
  2. Get to the colorway screen

Actual result:
3a. A random balanced colorway is selected
3b. Spotlight modal card becomes light (as underlying theme behind Balanced colorways is light).
3c. “Keep my nightly colors” is presented as a white icon.
4. Click “Keep my nightly colors”, the icon switches to a black one, the spotlight modal card becomes dark.
Screenshots of step 3 and step 4 are attached.

Expected result:
We need to discuss this in a bit more detail, as when we started opening a spotlight over a new tab, selecting a balanced theme for users with an existing dark theme became more visually jarring (as the user sees light Firefox Home behind the spotlight).

The goal is to avoid the visual “jump” for users who start with an underlying dark theme.

Approach 1
One way forward is to set a colorway with bold intensity if the user’s current underlying theme is dark.
In practice, this can happen when an existing user has:

  • Dark theme,
  • Old colorways with bold intensity,
  • Alpenglow with Dark system theme,
  • Alpenglow with Auto system theme and it's night time.

Downsides of this approach:

  1. We will create divergence with about:welcome where:
  • only balanced intensity will be offered to new users,
  • about:welcome respects users's web appearance setting.

Approach 2

  1. Keep offering dark theme users only balanced colorways.
  2. Spotlight modal respects web appearance, like about:welcome does.
  3. We don't need to turn off the randomization, as this removes the visual "jump" between the card color and chrome/Firefox Home.

This is also in line with what Colorways in Fx View do.

Priority: -- → P1
Severity: -- → S4
Iteration: --- → 106.2 - Sept 5 - Sept 16
Assignee: nobody → pdahiya
Depends on: 1787519, 1786627
See Also: → 1778483
Attachment #9294332 - Attachment description: Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity → Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a864c4b3d8a5
Existing user onboarding colorways screen should select user existing theme intensity r=Mardak
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

I have verified this defect and can confirm that a colorway with "bold" intensity is set under the following scenarios:

  • If the browser's "Dark" theme is active.
  • If an old "Colorway" theme with "bold" intensity is enabled.
  • If the browser's "Alpenglow" theme with the "Dark" system's theme is enabled.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220918214503) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: