179010 - localization note contains bad Unicode example

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Ying-Lin Xia]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; ja-JP; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; ja-JP; rv:1.0.1) Gecko/20020823 Netscape/7.0

/profile/resources/locale/en-US/migration.properties, line 1 -- # LOCALIZATION
NOTE: Do not translate Unicode (\uXXXX) characters.
/profile/resources/locale/en-US/migration.properties, line 14 -- # LOCALIZATION
NOTE: Do not translate Unicode (\uXXXX) characters.

Those \uXXXX breaks localization encoding convert tools.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ying-Lin Xia]

Those 2 examples need to be replaced by something else, like uXXXX...

Comment 2

[Simon Montagu :smontagu]

What if it was replace by the actual character used, \u000a? That would be the
clearest solution, but would the line feed cause problems to the tools?

Comment 3

[Ying-Lin Xia]

During our l10n process, we have to convert encoding from unicode to native very
often, back and forward. If put some real code in the note, the convert tool
will really convert it - I think it's fine if we do so...
Currently, with this kind of non-exist code example (XXXX), the convert tool
will stop right there, so we have to manually remove that bad example from the
note first.

Comment 4

[Ying-Lin Xia]

...sorry, line break code as example will make the case even worst, cause that
code will be really converted...

Comment 5

[nhottanscp]

Simon, please take care this.

Comment 6

[Simon Montagu :smontagu]

OK, let's just use some random Unicode codepoint like \u00a9 as an example.

Comment 7

[Simon Montagu :smontagu]

Attachment: Patch

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 105609 [details] [diff] [review]
Patch

sr=dveditz

Comment 9

[Simon Montagu :smontagu]

Fix checked in

Comment 10

[Yuying Long]

Ying, I think it's better that you could verify this instead of me. Thanks!

Comment 11

[Ying-Lin Xia]

Verified the fix in the trunk. Thanks, Simon!