1790147 - [foxfooding] Private Browsing window isn't on dark theme

Status: RESOLVED WONTFIX

(Firefox :: Private Browsing, defect, P3)

Description

[Peter deHaan [:pdehaan]]

Firefox Version: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:105.0) Gecko/20100101 Firefox/105.0
Window Size (inner width and height): 1969x1014

Steps to Reproduce

Expected Behavior

Private Browsing window should be on dark theme.

Actual Behavior

Comment 1

[Peter deHaan [:pdehaan]]

rtestard says

Is your browser theme light?
If your browser theme is set to light then private windows will be light, here are the rules for the theme:

Firefox theme set to “auto”

• Firefox theme follows the OS theme in normal windows
• Firefox theme set to dark in private windows
  • If the OS theme is set to “Dark” then content is dark in private and normal windows. Otherwise content is light.

Firefox theme set to “Dark”

• Firefox theme set to dark in normal windows
• Firefox theme set to dark in private windows
• Content is dark in private and normal windows.

Firefox theme set to “Light”

• Firefox theme set to light in normal windows
• Firefox theme set to light in private windows
• Content is light in private and normal windows.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:krupa--use, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Tim Huang[:timhuang]]

Hi Peter, could you provide more details? Like, in which settings your private windows are not on dark theme. Thanks.

Comment 4

[08xjcec48]

Tim, the problem is that you can't have this combination of options:

• OS theme: dark
• Firefox theme: light
• Private browsing theme: dark

Even if browser.theme.dark-private-windows is set to true, private windows are still light.

Comment 5

[Harshit Sohaney [:hsohaney]]

Do we know if this is intended behavior? Looking at https://searchfox.org/mozilla-central/source/toolkit/modules/LightweightThemeConsumer.sys.mjs#276, it looks like we want to have separate themes for pbmode and normal browsing, if this is the case, then this is a bug.

Comment 6

[Tim Huang[:timhuang]]

Yeah, we do want separate themes, but only if the Firefox theme is set to “auto”.

Paul, do you think comment 4 looks like an issue to you? Otherwise, we can close this bug.

Comment 7

[Emma Zühlcke [:emz]]

This is expected behaviour.