1790152 - avoid unnecessary string serializations when adding certificate error overrides

Status: RESOLVED FIXED

(Firefox :: Security, task)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The way certificate error overrides are added involves serializing security information back and forth between processes. Currently, much of that information is first serialized to a string and then sent across IPC, which is inefficient and unnecessary.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1790152 - avoid serializing nsITransportSecurityInfo in the certificate error page r?gijs

Only the bytes of the failed certificate chain are used, so that's all we need
to send across, rather than the entire nsITransportSecurityInfo.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1790152 - use nsIX509Cert directly in IPC in AddCertException r?nika

This avoids unnecessarily serializing the certificate to a string before
sending it over IPC.

Depends on D157007

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Security: PSM' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03f88676f2a2
avoid serializing nsITransportSecurityInfo in the certificate error page r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a6538d4b9ac5
use nsIX509Cert directly in IPC in AddCertException r=nika

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/03f88676f2a2
https://hg.mozilla.org/mozilla-central/rev/a6538d4b9ac5