1790164 - Vendor in libwebm and build a signs-of-life mkv demuxer

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, task, P4)

Description

[Brad Werth [:bradwerth]]

libwebm is capable of webm and mkv encode and decode. Using it would allow us to replace our usage of libnestegg and libmkv and give us more capabilities. Vendor in libwebm and build a minimum MKV demuxer that demonstrates that the library is correctly integrated.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1790164 Part 1: Vendor in libwebm.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1790164 Part 2: Add stub MKV decoder and demuxer.

Depends on D157014

Comment 3

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1790164 Part 3: Add MIME type sniffing for MKV.

Depends on D157015

Comment 4

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1790164 Part 3: Make MKVDemuxer read and report track info.

Depends on D157015

Comment 5

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1790164 Part 4: Make MKVDemuxer actually return samples.

Comment 6

[Brad Werth [:bradwerth]]

Attachment: HDR_Furby_VP9.mkv

This signs-of-life is at a good point to pause work and evaluate. The current stack of patches is capable of playing the attached VP9 encoded MKV with the following restrictions:

1. No seek support. Reload to play the video from the top.
2. In some cases the video fails to play the first time.
3. No audio is played, though the audio packets are being decoded.

Comment 7

[Brad Werth [:bradwerth]]

Jeff, would you please evaluate the work thus far and indicate if we want to proceed further, and if so what capabilities would you like to see next?

Comment 8

[Brad Werth [:bradwerth]]

We're going to leave this as a proof-of-concept that we might pick up again if we decide for sure to add MKV support. libwebm is viable, but no other browser is currently using it for MKV demuxing. Other options include using ffmpeg or expanding libnestegg to handle MKV. For now, we'll resolve this as INCOMPLETE.

Comment 9

[guest271314]

What codecs do you plan on supporting for MKV? If just VP9, VP8, and Opus all we have to do is change metadata to WebM and extension to .webm, correct?

Comment 10

[Phabricator Automation]

Comment on attachment 9294055 [details]
WIP: Bug 1790164 Part 2: Add stub MKV decoder and demuxer.

Revision D157015 was moved to bug 1631735. Setting attachment 9294055 [details] to obsolete.