1790203 - COEP Credentialless Origin-Trial crashes tab even without using COEP

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[niklas.fiekas]

The current tab always/unconditionally crashes immediately when visiting either of

• https://lichess.dev/ (not using COEP)
• https://lichess.dev/analysis (using COEP credentialless)

Both are served with

Origin-Trial: A11R4+BYwN6OiQqdWQQGBgNOtCTUAyhw3BRHhHxngWJmEmJNDBtNbTbnEXU/W645BTQKd+iHKXPGPFNKTnS9AB0AAABTeyJvcmlnaW4iOiJodHRwczovL2xpY2hlc3MuZGV2IiwiZmVhdHVyZSI6IkNvZXBDcmVkZW50aWFsbGVzcyIsImV4cGlyeSI6MTY3NTIwNTk0MH0=

as obtained from https://bugzilla.mozilla.org/show_bug.cgi?id=1790181.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ugh, thanks, that's nasty.

https://crash-stats.mozilla.org/report/index/45b9c3a4-dcc7-454e-9d7a-325550220910

Sean, it seems this assert is failing and the WindowContext might be null, can you take a look?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1790203 - Fix COEP: Credentialless when enabled via origin-trial header. r=sefeng,smaug

And add test coverage for it (we only had coverage for the meta tag,
ugh).

Comment 3

[Sean Feng [:sefeng]]

Emilio got this.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9294147 [details]
Bug 1790203 - Fix COEP: Credentialless when enabled via origin-trial header. r=sefeng,smaug

Beta/Release Uplift Approval Request

• User impact if declined: COEP: credentialless trial doesn't work. Patch is trivial (effectively a null-check + extra tests)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: visit lichess.dev
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Effectively a null-check
• String changes made/needed: none
• Is Android affected?: Yes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cf3ab594db9
Fix COEP: Credentialless when enabled via origin-trial header. r=sefeng

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to niklas.fiekas from comment #0)

Thanks a lot for the bug report! So the good thing is that, if you want to use the trial, you still can via the <meta> tag, and that should work.

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6cf3ab594db9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9294147 [details]
Bug 1790203 - Fix COEP: Credentialless when enabled via origin-trial header. r=sefeng,smaug

Approved for 105.0rc1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c82f8cf01ec7

Comment 10

[Monica Chiorean]

I was able to reproduce the issue on Nightly build.
Verified as fixed on Nightly 106.0a1(20220912094615).

Comment 11

[Monica Chiorean]

Issue is not reproducing on Win10, Ubuntu 20.04 and Mac 10.13 using Nightly 106.0a1(20220912094615) and Beta 105.0(20220912145803).

Comment 12

[Andrew McCreight [:mccr8]]

This is still showing up on crash-stats because people are using ancient Nightly versions, so I'll add the signature.