Closed
Bug 179021
Opened 23 years ago
Closed 23 years ago
Pressing Cancel in print dialog hangs control in WaitForComplete()
Categories
(Core Graveyard :: Embedding: ActiveX Wrapper, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3alpha
People
(Reporter: grahamf, Assigned: adamlock)
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
rods
:
review+
rpotts
:
superreview+
|
Details | Diff | Splinter Review |
When the print dialog is shown in the ActiveX control, pressing the Cancel
button causes a hang in the WaitForComplete() method on the print listener.
Essentially, the return code from Print() is not checked for NS_ERROR_ABORT,
which will indicate the dialog was cancelled. The print listener's
WaitForComplete() method is called, which will never terminate since there
will be no status updates.
Confirming, patch follows
Status: UNCONFIRMED → NEW
Ever confirmed: true
Patch checks return code, and also restures the print_progress pref to its old
value.
|
||
Updated•23 years ago
|
QA Contact: mdunn → ashishbhatt
Comment on attachment 105573 [details] [diff] [review]
Patch
Can I have an r/sr on this please. It looks pretty trivial to fix. I decided to
restore the print progress pref anyway, despite my last comment for bug 168510.
Attachment #105573 -
Flags: superreview?(rpotts)
Attachment #105573 -
Flags: review?(rods)
|
|
||
Comment 4•23 years ago
|
||
Comment on attachment 105573 [details] [diff] [review]
Patch
r=rods
Attachment #105573 -
Flags: review?(rods) → review+
|
|
||
Comment 5•23 years ago
|
||
Attachment #105573 -
Flags: superreview?(rpotts) → superreview+
Fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•