Closed Bug 1790222 Opened 2 years ago Closed 1 year ago

TSAN failures in WorkerScriptLoader::ShutdownScriptLoader()/CancelMainThread()

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jesup, Unassigned)

Details

(Keywords: csectype-race)

While running wpt tests, I noticed a number of TSAN failures in the worker code, in particular dom::workerinternals::loader::WorkerScriptLoader::ShutdownScriptLoader(), conflicting with dom::workerinternals::loader::WorkerScriptLoader::CancelMainThread()
https://treeherder.mozilla.org/logviewer?job_id=390110512&repo=try&lineNumber=2995

ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:67:13 in assign_assuming_AddRef

CancelMainThread():
if (IsCancelled() || !mWorkerRef) {
return;
}

ShutdownScriptLoader():
// Allow worker shutdown.
mWorkerRef = nullptr;

This should be addressed by https://phabricator.services.mozilla.com/D156943, which landed.

Can you confirm, Randell?

Flags: needinfo?(rjesup)

Seems fixed

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(rjesup)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.